Make structs readonly when applicable (#4002)
* Make all structs readonly when applicable. It should reduce amount of needless defensive copies * Make structs with trivial boilerplate equality code record structs * Remove unnecessary readonly modifiers from TextureCreateInfo * Make BitMap structs readonly too
This commit is contained in:
@@ -5,7 +5,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Common
|
||||
{
|
||||
static class KernelInit
|
||||
{
|
||||
private struct MemoryRegion
|
||||
private readonly struct MemoryRegion
|
||||
{
|
||||
public ulong Address { get; }
|
||||
public ulong Size { get; }
|
||||
|
@@ -2,7 +2,7 @@
|
||||
|
||||
namespace Ryujinx.HLE.HOS.Kernel.Common
|
||||
{
|
||||
struct OnScopeExit : IDisposable
|
||||
readonly struct OnScopeExit : IDisposable
|
||||
{
|
||||
private readonly Action _action;
|
||||
public OnScopeExit(Action action) => _action = action;
|
||||
|
@@ -17,7 +17,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Ipc
|
||||
(MemoryState)0xfffce5d4 //This is invalid, shouldn't be accessed.
|
||||
};
|
||||
|
||||
private struct Message
|
||||
private readonly struct Message
|
||||
{
|
||||
public ulong Address { get; }
|
||||
public ulong Size { get; }
|
||||
@@ -45,7 +45,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Ipc
|
||||
request.CustomCmdBuffSize) { }
|
||||
}
|
||||
|
||||
private struct MessageHeader
|
||||
private readonly struct MessageHeader
|
||||
{
|
||||
public uint Word0 { get; }
|
||||
public uint Word1 { get; }
|
||||
|
@@ -1,6 +1,6 @@
|
||||
namespace Ryujinx.HLE.HOS.Kernel.Process
|
||||
{
|
||||
struct ProcessCreationInfo
|
||||
readonly struct ProcessCreationInfo
|
||||
{
|
||||
public string Name { get; }
|
||||
|
||||
|
Reference in New Issue
Block a user