From 0fd926eff46c6c121760c2a3a9ada650eb1fb122 Mon Sep 17 00:00:00 2001 From: redphx <96280+redphx@users.noreply.github.com> Date: Mon, 23 Dec 2024 21:49:03 +0700 Subject: [PATCH] Fix note --- .../controller-customizations-manager-dialog.ts | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/modules/ui/dialog/profile-manger/controller-customizations-manager-dialog.ts b/src/modules/ui/dialog/profile-manger/controller-customizations-manager-dialog.ts index 7bbf5b7..ff721ef 100644 --- a/src/modules/ui/dialog/profile-manger/controller-customizations-manager-dialog.ts +++ b/src/modules/ui/dialog/profile-manger/controller-customizations-manager-dialog.ts @@ -29,7 +29,7 @@ export class ControllerCustomizationsManagerDialog extends BaseProfileManagerDia private $rightStickDeadzone!: BxDualNumberStepper; private $btnDetect!: HTMLButtonElement; - protected BLANK_PRESET_DATA = { + protected readonly BLANK_PRESET_DATA = { mapping: {}, settings: { leftTriggerRange: [0, 100], @@ -393,9 +393,18 @@ export class ControllerCustomizationsManagerDialog extends BaseProfileManagerDia } // Show note if it has settings other than 'vibrationIntensity' - const settingKeys = Object.keys(presetData.settings) as Array; - if (settingKeys.filter(key => key !== 'vibrationIntensity').length) { - showNote = true; + let key: keyof typeof presetData.settings; + for (key in presetData.settings) { + if (key === 'vibrationIntensity') { + continue; + } + + const value = presetData.settings[key]; + // Non-default value + if (Array.isArray(value) && (value[0] !== 0 || value[1] !== 100)) { + showNote = true; + break; + } } const fragment = document.createDocumentFragment();