From 5b67c344de5bbb25ad03259cfb0cf237a26ac848 Mon Sep 17 00:00:00 2001 From: redphx <96280+redphx@users.noreply.github.com> Date: Thu, 5 Dec 2024 17:18:47 +0700 Subject: [PATCH] Bug fixes --- dist/better-xcloud.lite.user.js | 3 ++- dist/better-xcloud.user.js | 3 ++- src/modules/ui/dialog/settings-dialog.ts | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/dist/better-xcloud.lite.user.js b/dist/better-xcloud.lite.user.js index 47a556d..f317345 100755 --- a/dist/better-xcloud.lite.user.js +++ b/dist/better-xcloud.lite.user.js @@ -4507,7 +4507,8 @@ class SettingsDialog extends NavigationDialog { $note, multiLines: setting.multiLines }); - $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`, $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control); + if (pref) $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`; + $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control); } renderSettingsSection(settingTab, sections) { let $tabContent = CE("div", { diff --git a/dist/better-xcloud.user.js b/dist/better-xcloud.user.js index b7266b0..c8b97ef 100755 --- a/dist/better-xcloud.user.js +++ b/dist/better-xcloud.user.js @@ -6413,7 +6413,8 @@ class SettingsDialog extends NavigationDialog { $note, multiLines: setting.multiLines }); - $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`, $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control); + if (pref) $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`; + $row.dataset.type = settingTabContent.group, $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control); } renderSettingsSection(settingTab, sections) { let $tabContent = CE("div", { diff --git a/src/modules/ui/dialog/settings-dialog.ts b/src/modules/ui/dialog/settings-dialog.ts index 157eaeb..39712d6 100755 --- a/src/modules/ui/dialog/settings-dialog.ts +++ b/src/modules/ui/dialog/settings-dialog.ts @@ -1007,7 +1007,9 @@ export class SettingsDialog extends NavigationDialog { $note, multiLines: setting.multiLines, }); - $row.htmlFor = `bx_setting_${escapeCssSelector(pref!)}`; + if (pref) { + $row.htmlFor = `bx_setting_${escapeCssSelector(pref)}`; + } $row.dataset.type = settingTabContent.group; $tabContent.appendChild($row);