Migrate Stream settings in Global storage to Stream storage

This commit is contained in:
redphx
2025-01-28 19:22:48 +07:00
parent 91f9d76c57
commit 6e31caa4fc
4 changed files with 39 additions and 14 deletions

View File

@@ -1,8 +1,32 @@
import { ALL_PREFS, GlobalPref, StreamPref, type AnyPref } from "@/enums/pref-keys";
import { ALL_PREFS, GlobalPref, StorageKey, StreamPref, type AnyPref } from "@/enums/pref-keys";
import type { PrefInfo, SettingActionOrigin } from "@/types/setting-definition";
import { GlobalSettingsStorage } from "./settings-storages/global-settings-storage";
import { StreamSettingsStorage } from "./settings-storages/stream-settings-storage";
// Migrate Stream settings in Global storage to Stream storage
function migrateStreamSettings() {
const storage = window.localStorage;
const globalSettings = JSON.parse(storage.getItem(StorageKey.GLOBAL) || '{}');
const streamSettings = JSON.parse(storage.getItem(StorageKey.STREAM) || '{}');
let modified = false;
for (const key in globalSettings) {
if (isStreamPref(key as AnyPref)) {
// Migration
if (!streamSettings.hasOwnProperty(key)) {
streamSettings[key] = globalSettings[key];
}
delete globalSettings[key];
modified = true;
}
}
if (modified) {
storage.setItem(StorageKey.GLOBAL, JSON.stringify(globalSettings));
storage.setItem(StorageKey.STREAM, JSON.stringify(streamSettings));
}
}
migrateStreamSettings();
export const STORAGE = {
Global: new GlobalSettingsStorage(),
Stream: new StreamSettingsStorage(),

View File

@@ -44,12 +44,6 @@ export class BaseSettingsStorage<T extends AnyPref> {
// Validate setting values
for (const key in settings) {
// Don't store invalid keys
if (!this.definitions.hasOwnProperty(key)) {
delete settings[key];
continue;
}
settings[key] = this.validateValue('get', key as T, settings[key]);
}