Don't store invalid keys in localStorage

2025-08-06 13:18:27 +02:00 · 2025-01-28 14:54:57 +07:00
parent d638700e03
commit d281db5767
3 changed files with 18 additions and 2 deletions
--- a/src/utils/settings-storages/base-settings-storage.ts
+++ b/src/utils/settings-storages/base-settings-storage.ts
@@ -44,6 +44,12 @@ export class BaseSettingsStorage<T extends AnyPref> {

        // Validate setting values
        for (const key in settings) {
+            // Don't store invalid keys
+            if (!this.definitions.hasOwnProperty(key)) {
+                delete settings[key];
+                continue;
+            }
+
            settings[key] = this.validateValue('get', key as T, settings[key]);
        }