marcel/better-xcloud
1
0
Fork 0
mirror of https://github.com/redphx/better-xcloud.git synced 2025-06-03 06:07:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't store invalid keys in localStorage

Browse Source
This commit is contained in:
redphx 2025-01-28 14:54:57 +07:00
parent d638700e03
commit d281db5767
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dist/better-xcloud.lite.user.js vendored
View File

@ -1102,8 +1102,13 @@ this.definitions = definitions, this._settings = null;
get settings() { get settings() {
if (this._settings) return this._settings; if (this._settings) return this._settings;
let settings = JSON.parse(this.storage.getItem(this.storageKey) || "{}"); let settings = JSON.parse(this.storage.getItem(this.storageKey) || "{}");
for (let key in settings) for (let key in settings) {
if (!this.definitions.hasOwnProperty(key)) {
delete settings[key];
continue;
}
settings[key] = this.validateValue("get", key, settings[key]); settings[key] = this.validateValue("get", key, settings[key]);
}
return this._settings = settings, settings; return this._settings = settings, settings;
} }
getDefinition(key) { getDefinition(key) {

7
dist/better-xcloud.user.js vendored
View File

@ -1174,8 +1174,13 @@ this.definitions = definitions, this._settings = null;
get settings() { get settings() {
if (this._settings) return this._settings; if (this._settings) return this._settings;
let settings = JSON.parse(this.storage.getItem(this.storageKey) || "{}"); let settings = JSON.parse(this.storage.getItem(this.storageKey) || "{}");
for (let key in settings) for (let key in settings) {
if (!this.definitions.hasOwnProperty(key)) {
delete settings[key];
continue;
}
settings[key] = this.validateValue("get", key, settings[key]); settings[key] = this.validateValue("get", key, settings[key]);
}
return this._settings = settings, settings; return this._settings = settings, settings;
} }
getDefinition(key) { getDefinition(key) {

6
src/utils/settings-storages/base-settings-storage.ts
View File

@ -44,6 +44,12 @@ export class BaseSettingsStorage<T extends AnyPref> {
// Validate setting values // Validate setting values
for (const key in settings) { for (const key in settings) {
// Don't store invalid keys
if (!this.definitions.hasOwnProperty(key)) {
delete settings[key];
continue;
}
settings[key] = this.validateValue('get', key as T, settings[key]); settings[key] = this.validateValue('get', key as T, settings[key]);
} }