From d292bef5e7e3f6f3afc8e4079c5052e13b64f0da Mon Sep 17 00:00:00 2001
From: redphx <96280+redphx@users.noreply.github.com>
Date: Mon, 9 Dec 2024 17:42:51 +0700
Subject: [PATCH] Only show unbind note on custom presets

---
 src/assets/css/navigation-dialog.styl                    | 1 +
 .../dialog/profile-manger/base-profile-manager-dialog.ts | 2 +-
 .../profile-manger/keyboard-shortcuts-manager-dialog.ts  | 9 ++++++++-
 .../dialog/profile-manger/mkb-mapping-manager-dialog.ts  | 6 +++++-
 4 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/assets/css/navigation-dialog.styl b/src/assets/css/navigation-dialog.styl
index 6b23f1b..2f0971f 100755
--- a/src/assets/css/navigation-dialog.styl
+++ b/src/assets/css/navigation-dialog.styl
@@ -221,5 +221,6 @@
 
     .bx-settings-row {
         background: none;
+        padding: 10px;
     }
 }
diff --git a/src/modules/ui/dialog/profile-manger/base-profile-manager-dialog.ts b/src/modules/ui/dialog/profile-manger/base-profile-manager-dialog.ts
index be8e82e..88043e6 100755
--- a/src/modules/ui/dialog/profile-manger/base-profile-manager-dialog.ts
+++ b/src/modules/ui/dialog/profile-manger/base-profile-manager-dialog.ts
@@ -174,7 +174,7 @@ export abstract class BaseProfileManagerDialog<T extends PresetRecord> extends N
                 $header,
                 this.$defaultNote = CE('div', { class: 'bx-default-preset-note bx-gone' }, t('default-preset-note')),
             ),
-            CE('div', { class: 'bx-dialog-content bx-hide-scroll-bar' }, this.$content),
+            CE('div', { class: 'bx-dialog-content' }, this.$content),
         );
     }
 
diff --git a/src/modules/ui/dialog/profile-manger/keyboard-shortcuts-manager-dialog.ts b/src/modules/ui/dialog/profile-manger/keyboard-shortcuts-manager-dialog.ts
index 34c62c5..d5ad527 100755
--- a/src/modules/ui/dialog/profile-manger/keyboard-shortcuts-manager-dialog.ts
+++ b/src/modules/ui/dialog/profile-manger/keyboard-shortcuts-manager-dialog.ts
@@ -19,6 +19,7 @@ export class KeyboardShortcutsManagerDialog extends BaseProfileManagerDialog<Key
     // private readonly LOG_TAG = 'KeyboardShortcutsManagerDialog';
 
     protected $content: HTMLElement;
+    private $unbindNote: HTMLElement;
     private readonly allKeyElements: BxKeyBindingButton[] = [];
 
     protected readonly BLANK_PRESET_DATA: KeyboardShortcutPresetData = {
@@ -65,7 +66,10 @@ export class KeyboardShortcutsManagerDialog extends BaseProfileManagerDialog<Key
             }
         }
 
-        this.$content = CE('div', {}, $rows);
+        this.$content = CE('div', {},
+            this.$unbindNote = CE('i', { class: 'bx-mkb-note' }, t('right-click-to-unbind')),
+            $rows,
+        );
     }
 
     private onKeyChanged = (e: Event) => {
@@ -109,6 +113,9 @@ export class KeyboardShortcutsManagerDialog extends BaseProfileManagerDialog<Key
         const isDefaultPreset = id <= 0;
         this.updateButtonStates();
 
+        // Toggle unbind note
+        this.$unbindNote.classList.toggle('bx-gone', isDefaultPreset);
+
         // Update buttons
         for (const $elm of this.allKeyElements) {
             const { action } = this.parseDataset($elm);
diff --git a/src/modules/ui/dialog/profile-manger/mkb-mapping-manager-dialog.ts b/src/modules/ui/dialog/profile-manger/mkb-mapping-manager-dialog.ts
index 469f8ee..921acb8 100755
--- a/src/modules/ui/dialog/profile-manger/mkb-mapping-manager-dialog.ts
+++ b/src/modules/ui/dialog/profile-manger/mkb-mapping-manager-dialog.ts
@@ -48,6 +48,7 @@ export class MkbMappingManagerDialog extends BaseProfileManagerDialog<MkbPresetR
     private $mouseSensitivityX!: BxNumberStepper;
     private $mouseSensitivityY!: BxNumberStepper;
     private $mouseDeadzone!: BxNumberStepper;
+    private $unbindNote!: HTMLElement;
 
     constructor(title: string) {
         super(title, MkbMappingPresetsTable.getInstance());
@@ -93,7 +94,7 @@ export class MkbMappingManagerDialog extends BaseProfileManagerDialog<MkbPresetR
 
     private render() {
         const $rows = CE('div', {},
-            CE('i', { class: 'bx-mkb-note' }, t('right-click-to-unbind')),
+            this.$unbindNote = CE('i', { class: 'bx-mkb-note' }, t('right-click-to-unbind')),
         );
 
         for (const buttonIndex of this.BUTTONS_ORDER) {
@@ -185,6 +186,9 @@ export class MkbMappingManagerDialog extends BaseProfileManagerDialog<MkbPresetR
         const isDefaultPreset = id <= 0;
         this.updateButtonStates();
 
+        // Toggle unbind note
+        this.$unbindNote.classList.toggle('bx-gone', isDefaultPreset);
+
         // Update buttons
         for (const $elm of this.allKeyElements) {
             const { buttonIndex, keySlot } = this.parseDataset($elm);