marcel/better-xcloud
1
0
Fork 0
mirror of https://github.com/redphx/better-xcloud.git synced 2025-06-06 07:37:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix not disabling unsupported features in Settings dialog

Browse Source
This commit is contained in:
redphx 2024-10-02 07:17:17 +07:00
parent 9007663a3a
commit eed0aa9d9e
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dist/better-xcloud.user.js vendored
View File

@ -5045,11 +5045,11 @@ class SettingsNavigationDialog extends NavigationDialog {
_nearby: { _nearby: {
orientation: "horizontal" orientation: "horizontal"
} }
}, $label = CE("span", { class: "bx-settings-label" }, label, note && CE("div", { class: "bx-settings-dialog-note" }, note), setting.unsupported && CE("div", { class: "bx-settings-dialog-note" }, t("browser-unsupported-feature"))), !setting.unsupported && $control), $link = $label.querySelector("a"); }, $label = CE("span", { class: "bx-settings-label" }, label, note ? CE("div", { class: "bx-settings-dialog-note" }, note) : prefDefinition?.unsupported && CE("div", { class: "bx-settings-dialog-note" }, t("browser-unsupported-feature"))), !prefDefinition?.unsupported && $control), $link = $label.querySelector("a");
if ($link) $link.classList.add("bx-focusable"), setNearby($label, { if ($link) $link.classList.add("bx-focusable"), setNearby($label, {
focus: $link focus: $link
}); });
$tabContent.appendChild($row), setting.onCreated && setting.onCreated(setting, $control); $tabContent.appendChild($row), !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control);
} }
setupDialog() { setupDialog() {
let $tabs, $settings; let $tabs, $settings;

8
src/modules/ui/dialog/settings-dialog.ts
View File

@ -1152,6 +1152,7 @@ export class SettingsNavigationDialog extends NavigationDialog {
} }
let $label; let $label;
const $row = CE('label', { const $row = CE('label', {
class: 'bx-settings-row', class: 'bx-settings-row',
for: `bx_setting_${pref}`, for: `bx_setting_${pref}`,
@ -1162,10 +1163,9 @@ export class SettingsNavigationDialog extends NavigationDialog {
}, },
$label = CE('span', {class: 'bx-settings-label'}, $label = CE('span', {class: 'bx-settings-label'},
label, label,
note && CE('div', {class: 'bx-settings-dialog-note'}, note), note ? CE('div', {class: 'bx-settings-dialog-note'}, note) : prefDefinition?.unsupported && CE('div', {class: 'bx-settings-dialog-note'}, t('browser-unsupported-feature')),
setting.unsupported && CE('div', {class: 'bx-settings-dialog-note'}, t('browser-unsupported-feature')),
), ),
!setting.unsupported && $control, !prefDefinition?.unsupported && $control,
); );
// Make link inside <label> focusable // Make link inside <label> focusable
@ -1178,7 +1178,7 @@ export class SettingsNavigationDialog extends NavigationDialog {
} }
$tabContent.appendChild($row); $tabContent.appendChild($row);
setting.onCreated && setting.onCreated(setting, $control); !prefDefinition?.unsupported && setting.onCreated && setting.onCreated(setting, $control);
} }
private setupDialog() { private setupDialog() {