Adopt and overhaul

* Fix license file location
* Fix mandatory string quotation
* Tweak to bash coding style preferences
* Appease shellharden

.SRCINFO

@@ -1,22 +1,22 @@
 pkgbase = brave-bin
-	pkgdesc = Web browser that blocks ads and trackers by default (binary release).
+	pkgdesc = Web browser that blocks ads and trackers by default (binary release)
 	pkgver = 1.26.77
-	pkgrel = 1
+	pkgrel = 2
 	epoch = 1
-	url = https://brave.com/download
+	url = https://brave.com
 	arch = x86_64
 	license = MPL2
 	license = BSD
 	license = custom:chromium
-	depends = gtk3
-	depends = nss
 	depends = alsa-lib
+	depends = gtk3
 	depends = libxss
+	depends = nss
 	depends = ttf-font
 	optdepends = cups: Printer support
 	optdepends = libgnome-keyring: Enable GNOME keyring support
 	optdepends = libnotify: Native notification support
-	provides = brave
+	provides = brave=1.26.77
 	provides = brave-browser
 	conflicts = brave
 	noextract = brave-bin-1.26.77.zip
@@ -25,9 +25,9 @@ pkgbase = brave-bin
 	source = brave-bin.sh
 	source = brave-browser.desktop
 	source = logo.png
-	sha512sums = ea70dd39df1b3b17d21b84177149f96a9226d69b3dbeecff5878c276f8feed831c761cb7650ee29bae4f729bccf5159ecf8b6484a9beccce3d72c52a5da10250
-	sha512sums = 6912f1e0b20f16078e15ce75eca61b29fd5c415c63df9bd69a547d402bf00599fdcbe1c0898b8d2dc865dc1b604f81e2ec21525ecc61a0fcafba0d9f87434540
-	sha512sums = cbfe2edc06d5962a8a1f13707c91b03e21cd621ba4a8ad80b7c6143c8fd5302f17fae9e26a9e33c5eca250cf3b223a9219f6b70de12e0f4ff9cf0a0b1e2a05df
-	sha512sums = d7bef52e336bd908d24bf3a084a1fc480831d27a3c80af4c31872465b6a0ce39bdf298e620ae9865526c974465807559cc75610b835e60b4358f65a8a8ff159e
+	sha256sums = 75af7ea3438ac80fee18372798d2c689384d8f1bc2f1dead5470047931f5b43c
+	sha256sums = ba7d57a3328c68e6a78e49506af0e238936e823b2f463e8087c20fcf4300232a
+	sha256sums = c07276b69c7304981525ecb022f92daf7ae125a4fb05ac3442157b50826e257a
+	sha256sums = 4a585cb8740f4c9ba267f0df19d894eb9fae1b9a6af4a3e44737b7d0bcbc104a
 
 pkgname = brave-bin

PKGBUILD

@@ -1,58 +1,61 @@
-# Contributor: Caleb Maclennan <caleb@alerque.com>
+# Maintainer: Caleb Maclennan <caleb@alerque.com>
+# Contributor: Andrés Rodríguez <hello@andres.codes>
 # Contributor: Jacob Mischka <jacob@mischka.me>
 # Contributor: Manuel Mazzuola <origin.of@gmail.com>
 # Contributor: Simón Oroño <simonorono@protonmail.com>
 # Contributor: now-im <now im 627 @ gmail . com>
 # Contributor: Giusy Digital <kurmikon at libero dot it>
-# Mantainer: Andrés Rodríguez <hello@andres.codes>
-# https://aur.archlinux.org/packages/brave-bin/
+
+# Version notes:
+# `curl https://brave-browser-downloads.s3.brave.com/latest/release.version`
+#
+# 1.27.108 known broken on Linux
 
 pkgname=brave-bin
 pkgver=1.26.77
-pkgrel=1
+pkgrel=2
 epoch=1
-pkgdesc="Web browser that blocks ads and trackers by default (binary release)."
-arch=("x86_64")
-url="https://brave.com/download"
-license=("MPL2" "BSD" "custom:chromium")
-depends=("gtk3" "nss" "alsa-lib" "libxss" "ttf-font")
-optdepends=("cups: Printer support"
-            "libgnome-keyring: Enable GNOME keyring support"
-            "libnotify: Native notification support")
-provides=("${pkgname%-bin}" "brave-browser")
+pkgdesc='Web browser that blocks ads and trackers by default (binary release)'
+arch=(x86_64)
+url='https://brave.com'
+license=(MPL2 BSD custom:chromium)
+depends=(alsa-lib
+         gtk3
+         libxss
+         nss
+         ttf-font)
+optdepends=('cups: Printer support'
+            'libgnome-keyring: Enable GNOME keyring support'
+            'libnotify: Native notification support')
+provides=("${pkgname%-bin}=$pkgver" 'brave-browser')
 conflicts=("${pkgname%-bin}")
-source=("$pkgname-$pkgver.zip::https://github.com/brave/brave-browser/releases/download/v${pkgver}/brave-browser-${pkgver}-linux-amd64.zip"
-        "$pkgname.sh"
-        "brave-browser.desktop"
-        "logo.png")
 options=(!strip)
-sha512sums=("ea70dd39df1b3b17d21b84177149f96a9226d69b3dbeecff5878c276f8feed831c761cb7650ee29bae4f729bccf5159ecf8b6484a9beccce3d72c52a5da10250"
-            "6912f1e0b20f16078e15ce75eca61b29fd5c415c63df9bd69a547d402bf00599fdcbe1c0898b8d2dc865dc1b604f81e2ec21525ecc61a0fcafba0d9f87434540"
-            "cbfe2edc06d5962a8a1f13707c91b03e21cd621ba4a8ad80b7c6143c8fd5302f17fae9e26a9e33c5eca250cf3b223a9219f6b70de12e0f4ff9cf0a0b1e2a05df"
-            "d7bef52e336bd908d24bf3a084a1fc480831d27a3c80af4c31872465b6a0ce39bdf298e620ae9865526c974465807559cc75610b835e60b4358f65a8a8ff159e")
+source=("$pkgname-$pkgver.zip::https://github.com/brave/brave-browser/releases/download/v$pkgver/brave-browser-$pkgver-linux-amd64.zip"
+        "$pkgname.sh"
+        'brave-browser.desktop'
+        'logo.png')
 noextract=("$pkgname-$pkgver.zip")
+sha256sums=('75af7ea3438ac80fee18372798d2c689384d8f1bc2f1dead5470047931f5b43c'
+            'ba7d57a3328c68e6a78e49506af0e238936e823b2f463e8087c20fcf4300232a'
+            'c07276b69c7304981525ecb022f92daf7ae125a4fb05ac3442157b50826e257a'
+            '4a585cb8740f4c9ba267f0df19d894eb9fae1b9a6af4a3e44737b7d0bcbc104a')
 
 prepare() {
 	mkdir -p brave
-  bsdtar -xf $pkgname-$pkgver.zip -C brave
+	bsdtar -xf "$pkgname-$pkgver.zip" -C brave
 	chmod +x brave/brave
 }
 
-_bsdtardir="brave"
-
 package() {
-    install -d -m0755 "$pkgdir/usr/lib"
-    cp -a $_bsdtardir "$pkgdir/usr/lib/$pkgname"
+	install -dm0755 "$pkgdir/usr/lib"
+	cp -a brave "$pkgdir/usr/lib/$pkgname"
 
 	# allow firejail users to get the suid sandbox working
-    chmod 4755 $pkgdir/usr/lib/brave-bin/chrome-sandbox
+	chmod 4755 "$pkgdir/usr/lib/brave-bin/chrome-sandbox"
 
 	install -Dm0755 "$pkgname.sh" "$pkgdir/usr/bin/brave"
-    install -Dm0644 -t "$pkgdir/usr/share/applications" "brave-browser.desktop"
+	install -Dm0644 -t "$pkgdir/usr/share/applications/" "brave-browser.desktop"
 	install -Dm0644 "logo.png" "$pkgdir/usr/share/pixmaps/brave-desktop.png"
-    LICENSES_DIR="$pkgdir/usr/share/licenses/$pkgname"
-    mkdir -p "$LICENSES_DIR"
-    if [ -f "$pkgdir/usr/lib/$pkgname/LICENSE" ] && [ -f "$pkgdir/usr/lib/$pkgname/LICENSES.chromium.html" ]; then
-      mv "$pkgdir/usr/lib/$pkgname/"{LICENSE,LICENSES.chromium.html} "$LICENSES_DIR"
-    fi
+    install -Dm0644 -t "$pkgdir/usr/share/licenses/$pkgname/" brave/LICENSE
+	rm "$pkgdir/usr/lib/$pkgname/LICENSE"
 }