marcel/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-11-25 23:24:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Restore arrow start point when self binding

Browse Source
This commit is contained in:
Mark Tolmacs
2025-11-08 15:45:43 +01:00
parent d93a6f09fe
commit 3ac0a3c3ef
3 changed files with 134 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/element/src/utils.ts
View File

@@ -31,6 +31,7 @@ import { elementCenterPoint, getDiamondPoints } from "./bounds";
import { generateLinearCollisionShape } from "./shape";
import { isPointInElement } from "./collision";
import { LinearElementEditor } from "./linearElementEditor";
import { isRectangularElement } from "./typeChecks";
@@ -557,14 +558,17 @@ export const projectFixedPointOntoDiagonal = (
element: ExcalidrawElement,
startOrEnd: "start" | "end",
elementsMap: ElementsMap,
) => {
): GlobalPoint | null => {
invariant(arrow.points.length >= 2, "Arrow must have at least two points");
if (arrow.width < 1 && arrow.height < 1) {
return null;
}
const [diagonalOne, diagonalTwo] = getDiagonalsForBindableElement(
element,
elementsMap,
);
invariant(arrow.points.length >= 2, "Arrow must have at least two points");
const a = LinearElementEditor.getPointAtIndexGlobalCoordinates(
arrow,
startOrEnd === "start" ? 1 : arrow.points.length - 2,
@@ -587,9 +591,12 @@ export const projectFixedPointOntoDiagonal = (
const d1 = p1 && pointDistance(a, p1);
const d2 = p2 && pointDistance(a, p2);
let p = null;
if (d1 != null && d2 != null) {
return d1 < d2 ? p1 : p2;
p = d1 < d2 ? p1 : p2;
} else {
p = p1 || p2 || null;
}
return p1 || p2 || null;
return p && isPointInElement(p, element, elementsMap) ? p : null;
};