From 7703cc25974fb122dbe26269fed55a4f6f891beb Mon Sep 17 00:00:00 2001 From: Mark Tolmacs Date: Sun, 7 Sep 2025 18:27:12 +0200 Subject: [PATCH] fix: Circular dep Signed-off-by: Mark Tolmacs --- packages/common/src/utils.ts | 10 +--------- packages/element/src/binding.ts | 12 +++++------- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/packages/common/src/utils.ts b/packages/common/src/utils.ts index 35638fc23..e90d2d82e 100644 --- a/packages/common/src/utils.ts +++ b/packages/common/src/utils.ts @@ -1,11 +1,6 @@ import { average } from "@excalidraw/math"; -import { isImageElement } from "@excalidraw/element"; -import type { - ExcalidrawBindableElement, - FontFamilyValues, - FontString, -} from "@excalidraw/element/types"; +import type { FontFamilyValues, FontString } from "@excalidraw/element/types"; import type { ActiveTool, @@ -567,9 +562,6 @@ export const isTransparent = (color: string) => { ); }; -export const isAlwaysInsideBinding = (element: ExcalidrawBindableElement) => - isImageElement(element); - export type ResolvablePromise = Promise & { resolve: [T] extends [undefined] ? (value?: MaybePromise>) => void diff --git a/packages/element/src/binding.ts b/packages/element/src/binding.ts index b0fa7762c..f6c0ff772 100644 --- a/packages/element/src/binding.ts +++ b/packages/element/src/binding.ts @@ -1,10 +1,4 @@ -import { - KEYS, - arrayToMap, - invariant, - isAlwaysInsideBinding, - isTransparent, -} from "@excalidraw/common"; +import { KEYS, arrayToMap, invariant, isTransparent } from "@excalidraw/common"; import { lineSegment, @@ -53,6 +47,7 @@ import { isBindableElement, isBoundToContainer, isElbowArrow, + isImageElement, isRectanguloidElement, isTextElement, } from "./typeChecks"; @@ -107,6 +102,9 @@ export const getFixedBindingDistance = ( element: ExcalidrawBindableElement, ): number => FIXED_BINDING_DISTANCE + element.strokeWidth / 2; +export const isAlwaysInsideBinding = (element: ExcalidrawBindableElement) => + isImageElement(element); + export const shouldEnableBindingForPointerEvent = ( event: React.PointerEvent, ) => {