marcel/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-09-24 01:40:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: False bind timeout indicator

Browse Source 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
This commit is contained in:
Mark Tolmacs
2025-09-22 18:22:35 +02:00
parent 83c7841bf1
commit 95f1c719c4
1 changed files with 45 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
packages/excalidraw/components/App.tsx
View File

@@ -1099,6 +1099,7 @@ class App extends React.Component<AppProps, AppState> {
isOverlapping = !!( isOverlapping = !!(
startBounds && startBounds &&
endBounds && endBounds &&
startElement.id !== endElement.id &&
doBoundsIntersect(startBounds, endBounds) doBoundsIntersect(startBounds, endBounds)
); );
} }
@@ -8517,48 +8518,55 @@ class App extends React.Component<AppProps, AppState> {
this.state, this.state,
{ newArrow: true }, { newArrow: true },
); );
this.handleDelayedBindModeChange(element, boundElement);
} }
this.setState((prevState) => { // NOTE: We need the flushSync here for the
let linearElementEditor = null; // delayed bind mode change to see the right state
let nextSelectedElementIds = prevState.selectedElementIds; // (specifically the `newElement`)
if (isLinearElement(element)) { flushSync(() => {
linearElementEditor = new LinearElementEditor( this.setState((prevState) => {
element, let linearElementEditor = null;
this.scene.getNonDeletedElementsMap(), let nextSelectedElementIds = prevState.selectedElementIds;
); if (isLinearElement(element)) {
linearElementEditor = new LinearElementEditor(
element,
this.scene.getNonDeletedElementsMap(),
);
const endIdx = element.points.length - 1; const endIdx = element.points.length - 1;
linearElementEditor = { linearElementEditor = {
...linearElementEditor, ...linearElementEditor,
selectedPointsIndices: [endIdx], selectedPointsIndices: [endIdx],
initialState: { initialState: {
...linearElementEditor.initialState, ...linearElementEditor.initialState,
lastClickedPoint: endIdx, lastClickedPoint: endIdx,
origin: pointFrom<GlobalPoint>( origin: pointFrom<GlobalPoint>(
pointerDownState.origin.x, pointerDownState.origin.x,
pointerDownState.origin.y, pointerDownState.origin.y,
), ),
}, },
};
}
nextSelectedElementIds = !this.state.activeTool.locked
? makeNextSelectedElementIds({ [element.id]: true }, prevState)
: prevState.selectedElementIds;
return {
...prevState,
bindMode: "orbit",
newElement: element,
startBoundElement: boundElement,
suggestedBinding: boundElement || null,
selectedElementIds: nextSelectedElementIds,
selectedLinearElement: linearElementEditor,
}; };
} });
nextSelectedElementIds = !this.state.activeTool.locked
? makeNextSelectedElementIds({ [element.id]: true }, prevState)
: prevState.selectedElementIds;
return {
...prevState,
bindMode: "orbit",
newElement: element,
startBoundElement: boundElement,
suggestedBinding: boundElement || null,
selectedElementIds: nextSelectedElementIds,
selectedLinearElement: linearElementEditor,
};
}); });
if (isBindingElement(element)) {
this.handleDelayedBindModeChange(element, boundElement);
}
} }
}; };