marcel/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-09-17 14:30:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Locked elbow arrow creation

Browse Source
This commit is contained in:
Mark Tolmacs
2025-09-14 14:05:55 +02:00
parent 4d8a1b29f6
commit b1006e2bfd
1 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/element/src/linearElementEditor.ts
View File

@@ -397,9 +397,11 @@ export class LinearElementEditor {
): Pick<AppState, "suggestedBinding" | "selectedLinearElement"> | null { ): Pick<AppState, "suggestedBinding" | "selectedLinearElement"> | null {
const elementsMap = app.scene.getNonDeletedElementsMap(); const elementsMap = app.scene.getNonDeletedElementsMap();
const elements = app.scene.getNonDeletedElements(); const elements = app.scene.getNonDeletedElements();
const { elbowed, elementId, initialState, selectedPointsIndices } = const { elbowed, elementId, initialState } = linearElementEditor;
linearElementEditor; const selectedPointsIndices = Array.from(
const { lastClickedPoint } = initialState; linearElementEditor.selectedPointsIndices ?? [],
);
let { lastClickedPoint } = initialState;
const element = LinearElementEditor.getElement(elementId, elementsMap); const element = LinearElementEditor.getElement(elementId, elementsMap);
invariant(element, "Element being dragged must exist in the scene"); invariant(element, "Element being dragged must exist in the scene");
@@ -411,6 +413,18 @@ export class LinearElementEditor {
"There must be selected points in order to drag them", "There must be selected points in order to drag them",
); );
if (elbowed) {
selectedPointsIndices.some((pointIdx, idx) => {
if (pointIdx > 0 && pointIdx !== element.points.length - 1) {
selectedPointsIndices[idx] = element.points.length - 1;
lastClickedPoint = element.points.length - 1;
return true;
}
return false;
});
}
invariant( invariant(
lastClickedPoint > -1 && lastClickedPoint > -1 &&
selectedPointsIndices.includes(lastClickedPoint) && selectedPointsIndices.includes(lastClickedPoint) &&
@@ -422,16 +436,6 @@ export class LinearElementEditor {
}) lastClickedPoint(${lastClickedPoint})`, }) lastClickedPoint(${lastClickedPoint})`,
); );
invariant(
!elbowed ||
selectedPointsIndices?.filter(
(idx) => idx !== 0 && idx !== element.points.length - 1,
).length === 0,
`Only start and end points can be selected for elbow arrows: ${JSON.stringify(
selectedPointsIndices,
)} end point ${element.points.length - 1}`,
);
// point that's being dragged (out of all selected points) // point that's being dragged (out of all selected points)
const draggingPoint = element.points[lastClickedPoint]; const draggingPoint = element.points[lastClickedPoint];
// The adjacent point to the one dragged point // The adjacent point to the one dragged point