fix: select instead of focus search input (#8483)

This commit is contained in:
David Luzar
2024-09-09 19:57:22 +02:00
committed by GitHub
parent 6959a363f0
commit d107215564
4 changed files with 17 additions and 20 deletions

View File

@@ -10,8 +10,6 @@ import type { ExcalidrawTextElement } from "../element/types";
import { measureText } from "../element/textElement";
import { addEventListener, getFontString } from "../utils";
import { KEYS } from "../keys";
import "./SearchMenu.scss";
import clsx from "clsx";
import { atom, useAtom } from "jotai";
import { jotaiScope } from "../jotai";
@@ -21,6 +19,8 @@ import { randomInteger } from "../random";
import { CLASSES, EVENT } from "../constants";
import { useStable } from "../hooks/useStable";
import "./SearchMenu.scss";
const searchKeywordAtom = atom<string>("");
export const searchItemInFocusAtom = atom<number | null>(null);
@@ -229,6 +229,7 @@ export const SearchMenu = () => {
});
}
searchInputRef.current?.focus();
searchInputRef.current?.select();
} else {
setAppState({
openSidebar: null,
@@ -264,16 +265,6 @@ export const SearchMenu = () => {
});
}, [setAppState, stableState, app]);
/**
* NOTE:
*
* for testing purposes, we're manually focusing instead of
* setting `selectOnRender` on <TextField>
*/
useEffect(() => {
searchInputRef.current?.focus();
}, []);
const matchCount = `${searchMatches.items.length} ${
searchMatches.items.length === 1
? t("search.singleResult")
@@ -292,6 +283,7 @@ export const SearchMenu = () => {
onChange={(value) => {
setKeyword(value);
}}
selectOnRender
/>
</div>