Compare commits

..

4 Commits

Author SHA1 Message Date
Aakansha Doshi
5f8321cf62 fix 2023-09-05 20:33:36 +05:30
Aakansha Doshi
dc6b0be87d fix 2023-09-05 20:29:10 +05:30
Aakansha Doshi
3b350ee904 ci: disable comment for bundle size check 2023-09-05 20:26:35 +05:30
David Luzar
27fd150a20 fix: canvas flickering due to resetting canvas on skipped frames (#6960) 2023-09-05 12:06:48 +02:00
3 changed files with 25 additions and 14 deletions

View File

@@ -3,6 +3,10 @@ on:
pull_request: pull_request:
branches: branches:
- master - master
permissions:
pull-requests: read
jobs: jobs:
size: size:
runs-on: ubuntu-latest runs-on: ubuntu-latest

View File

@@ -37,10 +37,25 @@ const StaticCanvas = (props: StaticCanvasProps) => {
canvas.classList.add("excalidraw__canvas", "static"); canvas.classList.add("excalidraw__canvas", "static");
} }
canvas.style.width = `${props.appState.width}px`; const widthString = `${props.appState.width}px`;
canvas.style.height = `${props.appState.height}px`; const heightString = `${props.appState.height}px`;
canvas.width = props.appState.width * props.scale; if (canvas.style.width !== widthString) {
canvas.height = props.appState.height * props.scale; canvas.style.width = widthString;
}
if (canvas.style.height !== heightString) {
canvas.style.height = heightString;
}
const scaledWidth = props.appState.width * props.scale;
const scaledHeight = props.appState.height * props.scale;
// setting width/height resets the canvas even if dimensions not changed,
// which would cause flicker when we skip frame (due to throttling)
if (canvas.width !== scaledWidth) {
canvas.width = scaledWidth;
}
if (canvas.height !== scaledHeight) {
canvas.height = scaledHeight;
}
renderStaticScene( renderStaticScene(
{ {

View File

@@ -89,19 +89,11 @@ module.exports = {
}), }),
], ],
splitChunks: { splitChunks: {
chunks: "all", chunks: "async",
cacheGroups: { cacheGroups: {
vendors: { vendors: {
test: /[\\/]node_modules[\\/]/, test: /[\\/]node_modules[\\/]/,
// cacheGroupKey here is `commons` as the key of the cacheGroup name: "vendor",
name(module, chunks, cacheGroupKey) {
const moduleFileName = module
.identifier()
.split("/")
.reduceRight((item) => item);
const allChunksNames = chunks.map((item) => item.name).join("~");
return `${cacheGroupKey}-${allChunksNames}-${moduleFileName}`;
},
}, },
}, },
}, },