Compare commits

..

5 Commits

Author SHA1 Message Date
zsviczian
60a3584e86 change css back to original 2023-10-07 10:38:46 +02:00
zsviczian
fa0e653236 lint 2023-10-07 10:37:37 +02:00
zsviczian
16de3d9243 add svgContainer offset 2023-10-07 10:35:06 +02:00
zsviczian
c65d6506f7 fix lasertool offset 2023-10-07 08:49:32 +02:00
David Luzar
a249f332a2 fix: ensure we do not stop laser update prematurely (#7100) 2023-10-06 12:00:35 +02:00
6 changed files with 49 additions and 83 deletions

View File

@@ -1211,7 +1211,6 @@ class App extends React.Component<AppProps, AppState> {
} }
app={this} app={this}
isCollaborating={this.props.isCollaborating} isCollaborating={this.props.isCollaborating}
uiDisabled={this.props.ui === false}
> >
{this.props.children} {this.props.children}
</LayerUI> </LayerUI>
@@ -1238,16 +1237,14 @@ class App extends React.Component<AppProps, AppState> {
closable={this.state.toast.closable} closable={this.state.toast.closable}
/> />
)} )}
{this.state.contextMenu && {this.state.contextMenu && (
this.props.interactive !== false && <ContextMenu
this.props.ui !== false && ( items={this.state.contextMenu.items}
<ContextMenu top={this.state.contextMenu.top}
items={this.state.contextMenu.items} left={this.state.contextMenu.left}
top={this.state.contextMenu.top} actionManager={this.actionManager}
left={this.state.contextMenu.left} />
actionManager={this.actionManager} )}
/>
)}
<StaticCanvas <StaticCanvas
canvas={this.canvas} canvas={this.canvas}
rc={this.rc} rc={this.rc}
@@ -2111,10 +2108,6 @@ class App extends React.Component<AppProps, AppState> {
event.preventDefault(); event.preventDefault();
} }
if (this.props.interactive === false) {
return;
}
if (!didTapTwice) { if (!didTapTwice) {
didTapTwice = true; didTapTwice = true;
clearTimeout(tappedTwiceTimer); clearTimeout(tappedTwiceTimer);
@@ -2149,10 +2142,6 @@ class App extends React.Component<AppProps, AppState> {
}; };
private onTouchEnd = (event: TouchEvent) => { private onTouchEnd = (event: TouchEvent) => {
if (this.props.interactive === false) {
return;
}
this.resetContextMenuTimer(); this.resetContextMenuTimer();
if (event.touches.length > 0) { if (event.touches.length > 0) {
this.setState({ this.setState({
@@ -2169,10 +2158,6 @@ class App extends React.Component<AppProps, AppState> {
public pasteFromClipboard = withBatchedUpdates( public pasteFromClipboard = withBatchedUpdates(
async (event: ClipboardEvent | null) => { async (event: ClipboardEvent | null) => {
if (this.props.interactive === false) {
return;
}
const isPlainPaste = !!(IS_PLAIN_PASTE && event); const isPlainPaste = !!(IS_PLAIN_PASTE && event);
// #686 // #686
@@ -3215,10 +3200,6 @@ class App extends React.Component<AppProps, AppState> {
private onGestureStart = withBatchedUpdates((event: GestureEvent) => { private onGestureStart = withBatchedUpdates((event: GestureEvent) => {
event.preventDefault(); event.preventDefault();
if (this.props.interactive === false) {
return false;
}
// we only want to deselect on touch screens because user may have selected // we only want to deselect on touch screens because user may have selected
// elements by mistake while zooming // elements by mistake while zooming
if (this.isTouchScreenMultiTouchGesture()) { if (this.isTouchScreenMultiTouchGesture()) {
@@ -3234,10 +3215,6 @@ class App extends React.Component<AppProps, AppState> {
private onGestureChange = withBatchedUpdates((event: GestureEvent) => { private onGestureChange = withBatchedUpdates((event: GestureEvent) => {
event.preventDefault(); event.preventDefault();
if (this.props.interactive === false) {
return false;
}
// onGestureChange only has zoom factor but not the center. // onGestureChange only has zoom factor but not the center.
// If we're on iPad or iPhone, then we recognize multi-touch and will // If we're on iPad or iPhone, then we recognize multi-touch and will
// zoom in at the right location in the touchmove handler // zoom in at the right location in the touchmove handler
@@ -3269,11 +3246,6 @@ class App extends React.Component<AppProps, AppState> {
// fires only on Safari // fires only on Safari
private onGestureEnd = withBatchedUpdates((event: GestureEvent) => { private onGestureEnd = withBatchedUpdates((event: GestureEvent) => {
event.preventDefault(); event.preventDefault();
if (this.props.interactive === false) {
return false;
}
// reselect elements only on touch screens (see onGestureStart) // reselect elements only on touch screens (see onGestureStart)
if (this.isTouchScreenMultiTouchGesture()) { if (this.isTouchScreenMultiTouchGesture()) {
this.setState({ this.setState({
@@ -3855,10 +3827,6 @@ class App extends React.Component<AppProps, AppState> {
private handleCanvasPointerMove = ( private handleCanvasPointerMove = (
event: React.PointerEvent<HTMLCanvasElement>, event: React.PointerEvent<HTMLCanvasElement>,
) => { ) => {
if (this.props.interactive === false) {
return false;
}
this.savePointer(event.clientX, event.clientY, this.state.cursorButton); this.savePointer(event.clientX, event.clientY, this.state.cursorButton);
if (gesture.pointers.has(event.pointerId)) { if (gesture.pointers.has(event.pointerId)) {
@@ -4511,10 +4479,8 @@ class App extends React.Component<AppProps, AppState> {
return; return;
} }
if (this.props.interactive !== false) { if (this.handleCanvasPanUsingWheelOrSpaceDrag(event)) {
if (this.handleCanvasPanUsingWheelOrSpaceDrag(event)) { return;
return;
}
} }
this.lastPointerDownEvent = event; this.lastPointerDownEvent = event;
@@ -4546,20 +4512,14 @@ class App extends React.Component<AppProps, AppState> {
selectedElementsAreBeingDragged: false, selectedElementsAreBeingDragged: false,
}); });
if ( if (this.handleDraggingScrollBar(event, pointerDownState)) {
this.props.interactive !== false &&
this.handleDraggingScrollBar(event, pointerDownState)
) {
return; return;
} }
this.clearSelectionIfNotUsingSelection(); this.clearSelectionIfNotUsingSelection();
this.updateBindingEnabledOnPointerMove(event); this.updateBindingEnabledOnPointerMove(event);
if ( if (this.handleSelectionOnPointerDown(event, pointerDownState)) {
this.props.interactive !== false &&
this.handleSelectionOnPointerDown(event, pointerDownState)
) {
return; return;
} }
@@ -4641,15 +4601,15 @@ class App extends React.Component<AppProps, AppState> {
const onPointerMove = const onPointerMove =
this.onPointerMoveFromPointerDownHandler(pointerDownState); this.onPointerMoveFromPointerDownHandler(pointerDownState);
const onPointerUp =
this.onPointerUpFromPointerDownHandler(pointerDownState);
const onKeyDown = this.onKeyDownFromPointerDownHandler(pointerDownState);
const onKeyUp = this.onKeyUpFromPointerDownHandler(pointerDownState);
lastPointerUp = onPointerUp;
if (!this.state.viewModeEnabled || this.state.activeTool.type === "laser") { if (!this.state.viewModeEnabled || this.state.activeTool.type === "laser") {
const onPointerUp =
this.onPointerUpFromPointerDownHandler(pointerDownState);
const onKeyDown = this.onKeyDownFromPointerDownHandler(pointerDownState);
const onKeyUp = this.onKeyUpFromPointerDownHandler(pointerDownState);
lastPointerUp = onPointerUp;
window.addEventListener(EVENT.POINTER_MOVE, onPointerMove); window.addEventListener(EVENT.POINTER_MOVE, onPointerMove);
window.addEventListener(EVENT.POINTER_UP, onPointerUp); window.addEventListener(EVENT.POINTER_UP, onPointerUp);
window.addEventListener(EVENT.KEYDOWN, onKeyDown); window.addEventListener(EVENT.KEYDOWN, onKeyDown);
@@ -7844,10 +7804,6 @@ class App extends React.Component<AppProps, AppState> {
) => { ) => {
event.preventDefault(); event.preventDefault();
if (this.props.interactive === false) {
return;
}
if ( if (
(("pointerType" in event.nativeEvent && (("pointerType" in event.nativeEvent &&
event.nativeEvent.pointerType === "touch") || event.nativeEvent.pointerType === "touch") ||
@@ -8259,7 +8215,7 @@ class App extends React.Component<AppProps, AppState> {
event: WheelEvent | React.WheelEvent<HTMLDivElement | HTMLCanvasElement>, event: WheelEvent | React.WheelEvent<HTMLDivElement | HTMLCanvasElement>,
) => { ) => {
event.preventDefault(); event.preventDefault();
if (isPanning || this.props.interactive === false) { if (isPanning) {
return; return;
} }

View File

@@ -91,7 +91,7 @@ export class LaserPathManager {
private collaboratorsState: Map<string, CollabolatorState> = new Map(); private collaboratorsState: Map<string, CollabolatorState> = new Map();
private rafId: number | undefined; private rafId: number | undefined;
private lastUpdate = 0; private isDrawing = false;
private container: SVGSVGElement | undefined; private container: SVGSVGElement | undefined;
constructor(private app: App) { constructor(private app: App) {
@@ -100,12 +100,19 @@ export class LaserPathManager {
destroy() { destroy() {
this.stop(); this.stop();
this.lastUpdate = 0; this.isDrawing = false;
this.ownState = instantiateCollabolatorState(); this.ownState = instantiateCollabolatorState();
this.collaboratorsState = new Map(); this.collaboratorsState = new Map();
} }
startPath(x: number, y: number) { startPath(x: number, y: number) {
if (this.container) {
this.container.style.top = "0px";
this.container.style.left = "0px";
const { x, y } = this.container.getBoundingClientRect();
this.container.style.top = `${-y}px`;
this.container.style.left = `${-x}px`;
}
this.ownState.currentPath = instantiatePath(); this.ownState.currentPath = instantiatePath();
this.ownState.currentPath.addPoint([x, y, performance.now()]); this.ownState.currentPath.addPoint([x, y, performance.now()]);
this.updatePath(this.ownState); this.updatePath(this.ownState);
@@ -127,7 +134,7 @@ export class LaserPathManager {
} }
private updatePath(state: CollabolatorState) { private updatePath(state: CollabolatorState) {
this.lastUpdate = performance.now(); this.isDrawing = true;
if (!this.isRunning) { if (!this.isRunning) {
this.start(); this.start();
@@ -160,7 +167,7 @@ export class LaserPathManager {
this.updateCollabolatorsState(); this.updateCollabolatorsState();
if (performance.now() - this.lastUpdate < DECAY_TIME * 2) { if (this.isDrawing) {
this.update(); this.update();
} else { } else {
this.isRunning = false; this.isRunning = false;
@@ -250,6 +257,8 @@ export class LaserPathManager {
return; return;
} }
let somePathsExist = false;
for (const [key, state] of this.collaboratorsState.entries()) { for (const [key, state] of this.collaboratorsState.entries()) {
if (!this.app.state.collaborators.has(key)) { if (!this.app.state.collaborators.has(key)) {
state.svg.remove(); state.svg.remove();
@@ -269,6 +278,10 @@ export class LaserPathManager {
paths += ` ${this.draw(state.currentPath)}`; paths += ` ${this.draw(state.currentPath)}`;
} }
if (paths.trim()) {
somePathsExist = true;
}
state.svg.setAttribute("d", paths); state.svg.setAttribute("d", paths);
state.svg.setAttribute("fill", getClientColor(key)); state.svg.setAttribute("fill", getClientColor(key));
} }
@@ -287,7 +300,17 @@ export class LaserPathManager {
paths += ` ${this.draw(this.ownState.currentPath)}`; paths += ` ${this.draw(this.ownState.currentPath)}`;
} }
paths = paths.trim();
if (paths) {
somePathsExist = true;
}
this.ownState.svg.setAttribute("d", paths); this.ownState.svg.setAttribute("d", paths);
this.ownState.svg.setAttribute("fill", "red"); this.ownState.svg.setAttribute("fill", "red");
if (!somePathsExist) {
this.isDrawing = false;
}
} }
} }

View File

@@ -6,7 +6,6 @@
position: fixed; position: fixed;
top: 0; top: 0;
left: 0; left: 0;
z-index: 2; z-index: 2;
.LaserToolOverlayCanvas { .LaserToolOverlayCanvas {

View File

@@ -79,7 +79,6 @@ interface LayerUIProps {
children?: React.ReactNode; children?: React.ReactNode;
app: AppClassProperties; app: AppClassProperties;
isCollaborating: boolean; isCollaborating: boolean;
uiDisabled: boolean;
} }
const DefaultMainMenu: React.FC<{ const DefaultMainMenu: React.FC<{
@@ -138,7 +137,6 @@ const LayerUI = ({
children, children,
app, app,
isCollaborating, isCollaborating,
uiDisabled,
}: LayerUIProps) => { }: LayerUIProps) => {
const device = useDevice(); const device = useDevice();
const tunnels = useInitializeTunnels(); const tunnels = useInitializeTunnels();
@@ -356,10 +354,6 @@ const LayerUI = ({
const isSidebarDocked = useAtomValue(isSidebarDockedAtom, jotaiScope); const isSidebarDocked = useAtomValue(isSidebarDockedAtom, jotaiScope);
if (uiDisabled) {
return null;
}
const layerUIJSX = ( const layerUIJSX = (
<> <>
{/* ------------------------- tunneled UI ---------------------------- */} {/* ------------------------- tunneled UI ---------------------------- */}

View File

@@ -44,8 +44,6 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
children, children,
validateEmbeddable, validateEmbeddable,
renderEmbeddable, renderEmbeddable,
ui,
interactive,
} = props; } = props;
const canvasActions = props.UIOptions?.canvasActions; const canvasActions = props.UIOptions?.canvasActions;
@@ -102,7 +100,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
onPointerUpdate={onPointerUpdate} onPointerUpdate={onPointerUpdate}
renderTopRightUI={renderTopRightUI} renderTopRightUI={renderTopRightUI}
langCode={langCode} langCode={langCode}
viewModeEnabled={interactive === false ? true : viewModeEnabled} viewModeEnabled={viewModeEnabled}
zenModeEnabled={zenModeEnabled} zenModeEnabled={zenModeEnabled}
gridModeEnabled={gridModeEnabled} gridModeEnabled={gridModeEnabled}
libraryReturnUrl={libraryReturnUrl} libraryReturnUrl={libraryReturnUrl}
@@ -121,8 +119,6 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
onScrollChange={onScrollChange} onScrollChange={onScrollChange}
validateEmbeddable={validateEmbeddable} validateEmbeddable={validateEmbeddable}
renderEmbeddable={renderEmbeddable} renderEmbeddable={renderEmbeddable}
ui={ui}
interactive={interactive}
> >
{children} {children}
</App> </App>

View File

@@ -445,8 +445,6 @@ export interface ExcalidrawProps {
element: NonDeleted<ExcalidrawEmbeddableElement>, element: NonDeleted<ExcalidrawEmbeddableElement>,
appState: AppState, appState: AppState,
) => JSX.Element | null; ) => JSX.Element | null;
interactive?: boolean;
ui?: boolean;
} }
export type SceneData = { export type SceneData = {