mirror of
https://github.com/excalidraw/excalidraw.git
synced 2025-08-17 23:39:46 +02:00

Fix binding Remove unneeded params Unfinished simple arrow avoidance Fix newly created jumping arrow when gets outside Do not apply the jumping logic to elbow arrows for new elements Existing arrows now jump out Type updates to support fixed binding for simple arrows Fix crash for elbow arrws in mutateElement() Refactored simple arrow creation Updating tests No confirm threshold when inside biding range Fix multi-point arrow grid off Make elbow arrows respect grids Unbind arrow if bound and moved at shaft of arrow key Fix binding test Fix drag unbind when the bound element is in the selection Do not move mid point for simple arrows bound on both ends Add test for mobing mid points for simple arrows when bound on the same element on both ends Fix linear editor bug when both midpoint and endpoint is moved Fix all point multipoint arrow highlight and binding Arrow dragging gets a little drag to avoid accidental unbinding Fixed point binding for simple arrows when the arrow doesn't point to the element Fix binding disabled use-case triggering arrow editor Timed binding mode change for simple arrows Apply fixes Remove code to unbind on drag Update simple arrow fixed point when arrow is dragged or moved by arrow keys Binding highlight fixes Change bind mode timeout logic Fix tests Add Alt bindMode switch No dragging of arrows when bound, similar to elbow Fix timeout not taking effect immediately Bumop z-index for arrows when dragged Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Only transparent bindables allow binding fallthrough Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix lint Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix point click array creation interaction with fixed point binding Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Restrict new behavior to arrows only Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Allow binding inside images Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix already existing fixed binding retention Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Refactor and implement fixed point binding for unfilled elements Restore drag Removed point binding Binding code refactor Added centered focus point Binding & focus point debug Add invariants to check binding integrity in elements Binding fixes Small refactors Completely rewritten binding Include point updates after binding update Fix point updates when endpoint dragged and opposite endpoint orbits centered focus point only for new arrows Make z-index arrow reorder on bind Turn off inside binding mode after leaving a shape Remove invariants from debug feat: expose `applyTo` options, don't commit empty text element (#9744) * Expose applyTo options, skip re-draw for empty text * Don't commit empty text elements test: added test file for distribute (#9754) z-index update Bind mode on precise binding Fix binding to inside element Fix initial arrow not following cursor (white dot) Fix elbow arrow Fix z-index so it works on hover Fix fixed angle orbiting Move point click arrow creation over to common strategy Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Add binding strategy for drag arrow creation Fix elbow arrow Fix point handles Snap to center Fix transparent shape binding Internal arrow creation fix Fix point binding Fix selection bug Fix new arrow focus point Images now always bind inside Flashing arrow creation on binding band Add watchState debug method to window.h Fix debug canvas crash Remove non-needed bind mode Fix restore No keyboard movement when bound Add actionFinalize when arrow in edit mode Add drag to the Stats panel when bound arrow is moved Further simplify curve tracking Add typing to action register() Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix point at finalize Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix type errors Signed-off-by: Mark Tolmacs <mark@lazycat.hu> New arrow binding rules Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix cyclical dep Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fix jiggly arrows Fix jiggly arrow x2 Long inside-other binding Click-click binding Fix arrows Performance [PERF] Replace in-place Jacobian derivation with analytical version Different approach to inside binding Signed-off-by: Mark Tolmacs <mark@lazycat.hu> Fixes Fix inconsistent arrow start jump out Change how images are bound to on new arrow creation Lower timeout Small insurance fix
516 lines
12 KiB
TypeScript
516 lines
12 KiB
TypeScript
import {
|
|
ArrowheadArrowIcon,
|
|
CloseIcon,
|
|
TrashIcon,
|
|
} from "@excalidraw/excalidraw/components/icons";
|
|
import {
|
|
bootstrapCanvas,
|
|
getNormalizedCanvasDimensions,
|
|
} from "@excalidraw/excalidraw/renderer/helpers";
|
|
import { type AppState } from "@excalidraw/excalidraw/types";
|
|
import { arrayToMap, invariant, throttleRAF } from "@excalidraw/common";
|
|
import { useCallback } from "react";
|
|
|
|
import {
|
|
getGlobalFixedPointForBindableElement,
|
|
isArrowElement,
|
|
isBindableElement,
|
|
} from "@excalidraw/element";
|
|
|
|
import {
|
|
isLineSegment,
|
|
type GlobalPoint,
|
|
type LineSegment,
|
|
} from "@excalidraw/math";
|
|
import { isCurve } from "@excalidraw/math/curve";
|
|
|
|
import React from "react";
|
|
|
|
import type { Curve } from "@excalidraw/math";
|
|
import type { DebugElement } from "@excalidraw/common";
|
|
import type {
|
|
ElementsMap,
|
|
ExcalidrawArrowElement,
|
|
ExcalidrawBindableElement,
|
|
FixedPointBinding,
|
|
OrderedExcalidrawElement,
|
|
} from "@excalidraw/element/types";
|
|
|
|
import { STORAGE_KEYS } from "../app_constants";
|
|
|
|
const renderLine = (
|
|
context: CanvasRenderingContext2D,
|
|
zoom: number,
|
|
segment: LineSegment<GlobalPoint>,
|
|
color: string,
|
|
) => {
|
|
context.save();
|
|
context.strokeStyle = color;
|
|
context.beginPath();
|
|
context.moveTo(segment[0][0] * zoom, segment[0][1] * zoom);
|
|
context.lineTo(segment[1][0] * zoom, segment[1][1] * zoom);
|
|
context.stroke();
|
|
context.restore();
|
|
};
|
|
|
|
const renderCubicBezier = (
|
|
context: CanvasRenderingContext2D,
|
|
zoom: number,
|
|
[start, control1, control2, end]: Curve<GlobalPoint>,
|
|
color: string,
|
|
) => {
|
|
context.save();
|
|
context.strokeStyle = color;
|
|
context.beginPath();
|
|
context.moveTo(start[0] * zoom, start[1] * zoom);
|
|
context.bezierCurveTo(
|
|
control1[0] * zoom,
|
|
control1[1] * zoom,
|
|
control2[0] * zoom,
|
|
control2[1] * zoom,
|
|
end[0] * zoom,
|
|
end[1] * zoom,
|
|
);
|
|
context.stroke();
|
|
context.restore();
|
|
};
|
|
|
|
const renderOrigin = (context: CanvasRenderingContext2D, zoom: number) => {
|
|
context.strokeStyle = "#888";
|
|
context.save();
|
|
context.beginPath();
|
|
context.moveTo(-10 * zoom, -10 * zoom);
|
|
context.lineTo(10 * zoom, 10 * zoom);
|
|
context.moveTo(10 * zoom, -10 * zoom);
|
|
context.lineTo(-10 * zoom, 10 * zoom);
|
|
context.stroke();
|
|
context.save();
|
|
};
|
|
|
|
const _renderBinding = (
|
|
context: CanvasRenderingContext2D,
|
|
binding: FixedPointBinding,
|
|
elementsMap: ElementsMap,
|
|
zoom: number,
|
|
width: number,
|
|
height: number,
|
|
color: string,
|
|
) => {
|
|
if (!binding.fixedPoint) {
|
|
console.warn("Binding must have a fixedPoint");
|
|
return;
|
|
}
|
|
|
|
const bindable = elementsMap.get(
|
|
binding.elementId,
|
|
) as ExcalidrawBindableElement;
|
|
const [x, y] = getGlobalFixedPointForBindableElement(
|
|
binding.fixedPoint,
|
|
bindable,
|
|
elementsMap,
|
|
);
|
|
|
|
context.save();
|
|
context.strokeStyle = color;
|
|
context.lineWidth = 1;
|
|
context.beginPath();
|
|
context.moveTo(x * zoom, y * zoom);
|
|
context.bezierCurveTo(
|
|
x * zoom - width,
|
|
y * zoom - height,
|
|
x * zoom - width,
|
|
y * zoom + height,
|
|
x * zoom,
|
|
y * zoom,
|
|
);
|
|
context.stroke();
|
|
context.restore();
|
|
};
|
|
|
|
const _renderBindableBinding = (
|
|
binding: FixedPointBinding,
|
|
context: CanvasRenderingContext2D,
|
|
elementsMap: ElementsMap,
|
|
zoom: number,
|
|
width: number,
|
|
height: number,
|
|
color: string,
|
|
) => {
|
|
const bindable = elementsMap.get(
|
|
binding.elementId,
|
|
) as ExcalidrawBindableElement;
|
|
if (!binding.fixedPoint) {
|
|
console.warn("Binding must have a fixedPoint");
|
|
return;
|
|
}
|
|
|
|
const [x, y] = getGlobalFixedPointForBindableElement(
|
|
binding.fixedPoint,
|
|
bindable,
|
|
elementsMap,
|
|
);
|
|
|
|
context.save();
|
|
context.strokeStyle = color;
|
|
context.lineWidth = 1;
|
|
context.beginPath();
|
|
context.moveTo(x * zoom, y * zoom);
|
|
context.bezierCurveTo(
|
|
x * zoom + width,
|
|
y * zoom + height,
|
|
x * zoom + width,
|
|
y * zoom - height,
|
|
x * zoom,
|
|
y * zoom,
|
|
);
|
|
context.stroke();
|
|
context.restore();
|
|
};
|
|
|
|
const renderBindings = (
|
|
context: CanvasRenderingContext2D,
|
|
elements: readonly OrderedExcalidrawElement[],
|
|
zoom: number,
|
|
) => {
|
|
const elementsMap = arrayToMap(elements);
|
|
const dim = 16;
|
|
elements.forEach((element) => {
|
|
if (element.isDeleted) {
|
|
return;
|
|
}
|
|
|
|
if (isArrowElement(element)) {
|
|
if (element.startBinding) {
|
|
invariant(
|
|
elementsMap
|
|
.get(element.startBinding.elementId)
|
|
?.boundElements?.find((e) => e.id === element.id),
|
|
"Missing record in boundElements for arrow",
|
|
);
|
|
|
|
_renderBinding(
|
|
context,
|
|
element.startBinding,
|
|
elementsMap,
|
|
zoom,
|
|
dim,
|
|
dim,
|
|
"red",
|
|
);
|
|
}
|
|
|
|
if (element.endBinding) {
|
|
_renderBinding(
|
|
context,
|
|
element.endBinding,
|
|
elementsMap,
|
|
zoom,
|
|
dim,
|
|
dim,
|
|
"red",
|
|
);
|
|
}
|
|
}
|
|
|
|
if (isBindableElement(element) && element.boundElements?.length) {
|
|
element.boundElements.forEach((boundElement) => {
|
|
if (boundElement.type !== "arrow") {
|
|
return;
|
|
}
|
|
|
|
const arrow = elementsMap.get(
|
|
boundElement.id,
|
|
) as ExcalidrawArrowElement;
|
|
|
|
if (arrow && arrow.startBinding?.elementId === element.id) {
|
|
_renderBindableBinding(
|
|
arrow.startBinding,
|
|
context,
|
|
elementsMap,
|
|
zoom,
|
|
dim,
|
|
dim,
|
|
"green",
|
|
);
|
|
}
|
|
if (arrow && arrow.endBinding?.elementId === element.id) {
|
|
_renderBindableBinding(
|
|
arrow.endBinding,
|
|
context,
|
|
elementsMap,
|
|
zoom,
|
|
dim,
|
|
dim,
|
|
"green",
|
|
);
|
|
}
|
|
});
|
|
}
|
|
});
|
|
};
|
|
|
|
const render = (
|
|
frame: DebugElement[],
|
|
context: CanvasRenderingContext2D,
|
|
appState: AppState,
|
|
) => {
|
|
frame.forEach((el: DebugElement) => {
|
|
switch (true) {
|
|
case isLineSegment(el.data):
|
|
renderLine(
|
|
context,
|
|
appState.zoom.value,
|
|
el.data as LineSegment<GlobalPoint>,
|
|
el.color,
|
|
);
|
|
break;
|
|
case isCurve(el.data):
|
|
renderCubicBezier(
|
|
context,
|
|
appState.zoom.value,
|
|
el.data as Curve<GlobalPoint>,
|
|
el.color,
|
|
);
|
|
break;
|
|
default:
|
|
throw new Error(`Unknown element type ${JSON.stringify(el)}`);
|
|
}
|
|
});
|
|
};
|
|
|
|
const _debugRenderer = (
|
|
canvas: HTMLCanvasElement,
|
|
appState: AppState,
|
|
elements: readonly OrderedExcalidrawElement[],
|
|
scale: number,
|
|
) => {
|
|
const [normalizedWidth, normalizedHeight] = getNormalizedCanvasDimensions(
|
|
canvas,
|
|
scale,
|
|
);
|
|
|
|
const context = bootstrapCanvas({
|
|
canvas,
|
|
scale,
|
|
normalizedWidth,
|
|
normalizedHeight,
|
|
viewBackgroundColor: "transparent",
|
|
});
|
|
|
|
// Apply zoom
|
|
context.save();
|
|
context.translate(
|
|
appState.scrollX * appState.zoom.value,
|
|
appState.scrollY * appState.zoom.value,
|
|
);
|
|
|
|
renderOrigin(context, appState.zoom.value);
|
|
renderBindings(context, elements, appState.zoom.value);
|
|
|
|
if (
|
|
window.visualDebug?.currentFrame &&
|
|
window.visualDebug?.data &&
|
|
window.visualDebug.data.length > 0
|
|
) {
|
|
// Render only one frame
|
|
const [idx] = debugFrameData();
|
|
|
|
render(window.visualDebug.data[idx], context, appState);
|
|
} else {
|
|
// Render all debug frames
|
|
window.visualDebug?.data.forEach((frame) => {
|
|
render(frame, context, appState);
|
|
});
|
|
}
|
|
|
|
if (window.visualDebug) {
|
|
window.visualDebug!.data =
|
|
window.visualDebug?.data.map((frame) =>
|
|
frame.filter((el) => el.permanent),
|
|
) ?? [];
|
|
}
|
|
};
|
|
|
|
const debugFrameData = (): [number, number] => {
|
|
const currentFrame = window.visualDebug?.currentFrame ?? 0;
|
|
const frameCount = window.visualDebug?.data.length ?? 0;
|
|
|
|
if (frameCount > 0) {
|
|
return [currentFrame % frameCount, window.visualDebug?.currentFrame ?? 0];
|
|
}
|
|
|
|
return [0, 0];
|
|
};
|
|
|
|
export const saveDebugState = (debug: { enabled: boolean }) => {
|
|
try {
|
|
localStorage.setItem(
|
|
STORAGE_KEYS.LOCAL_STORAGE_DEBUG,
|
|
JSON.stringify(debug),
|
|
);
|
|
} catch (error: any) {
|
|
console.error(error);
|
|
}
|
|
};
|
|
|
|
export const debugRenderer = throttleRAF(
|
|
(
|
|
canvas: HTMLCanvasElement,
|
|
appState: AppState,
|
|
elements: readonly OrderedExcalidrawElement[],
|
|
scale: number,
|
|
) => {
|
|
_debugRenderer(canvas, appState, elements, scale);
|
|
},
|
|
{ trailing: true },
|
|
);
|
|
|
|
export const loadSavedDebugState = () => {
|
|
let debug;
|
|
try {
|
|
const savedDebugState = localStorage.getItem(
|
|
STORAGE_KEYS.LOCAL_STORAGE_DEBUG,
|
|
);
|
|
if (savedDebugState) {
|
|
debug = JSON.parse(savedDebugState) as { enabled: boolean };
|
|
}
|
|
} catch (error: any) {
|
|
console.error(error);
|
|
}
|
|
|
|
return debug ?? { enabled: false };
|
|
};
|
|
|
|
export const isVisualDebuggerEnabled = () =>
|
|
Array.isArray(window.visualDebug?.data);
|
|
|
|
export const DebugFooter = ({ onChange }: { onChange: () => void }) => {
|
|
const moveForward = useCallback(() => {
|
|
if (
|
|
!window.visualDebug?.currentFrame ||
|
|
isNaN(window.visualDebug?.currentFrame ?? -1)
|
|
) {
|
|
window.visualDebug!.currentFrame = 0;
|
|
}
|
|
window.visualDebug!.currentFrame += 1;
|
|
onChange();
|
|
}, [onChange]);
|
|
const moveBackward = useCallback(() => {
|
|
if (
|
|
!window.visualDebug?.currentFrame ||
|
|
isNaN(window.visualDebug?.currentFrame ?? -1) ||
|
|
window.visualDebug?.currentFrame < 1
|
|
) {
|
|
window.visualDebug!.currentFrame = 1;
|
|
}
|
|
window.visualDebug!.currentFrame -= 1;
|
|
onChange();
|
|
}, [onChange]);
|
|
const reset = useCallback(() => {
|
|
window.visualDebug!.currentFrame = undefined;
|
|
onChange();
|
|
}, [onChange]);
|
|
const trashFrames = useCallback(() => {
|
|
if (window.visualDebug) {
|
|
window.visualDebug.currentFrame = undefined;
|
|
window.visualDebug.data = [];
|
|
}
|
|
onChange();
|
|
}, [onChange]);
|
|
|
|
return (
|
|
<>
|
|
<button
|
|
className="ToolIcon_type_button"
|
|
data-testid="debug-forward"
|
|
aria-label="Move forward"
|
|
type="button"
|
|
onClick={trashFrames}
|
|
>
|
|
<div
|
|
className="ToolIcon__icon"
|
|
aria-hidden="true"
|
|
aria-disabled="false"
|
|
>
|
|
{TrashIcon}
|
|
</div>
|
|
</button>
|
|
<button
|
|
className="ToolIcon_type_button"
|
|
data-testid="debug-forward"
|
|
aria-label="Move forward"
|
|
type="button"
|
|
onClick={moveBackward}
|
|
>
|
|
<div
|
|
className="ToolIcon__icon"
|
|
aria-hidden="true"
|
|
aria-disabled="false"
|
|
>
|
|
<ArrowheadArrowIcon flip />
|
|
</div>
|
|
</button>
|
|
<button
|
|
className="ToolIcon_type_button"
|
|
data-testid="debug-forward"
|
|
aria-label="Move forward"
|
|
type="button"
|
|
onClick={reset}
|
|
>
|
|
<div
|
|
className="ToolIcon__icon"
|
|
aria-hidden="true"
|
|
aria-disabled="false"
|
|
>
|
|
{CloseIcon}
|
|
</div>
|
|
</button>
|
|
<button
|
|
className="ToolIcon_type_button"
|
|
data-testid="debug-backward"
|
|
aria-label="Move backward"
|
|
type="button"
|
|
onClick={moveForward}
|
|
>
|
|
<div
|
|
className="ToolIcon__icon"
|
|
aria-hidden="true"
|
|
aria-disabled="false"
|
|
>
|
|
<ArrowheadArrowIcon />
|
|
</div>
|
|
</button>
|
|
</>
|
|
);
|
|
};
|
|
|
|
interface DebugCanvasProps {
|
|
appState: AppState;
|
|
scale: number;
|
|
}
|
|
|
|
const DebugCanvas = React.forwardRef<HTMLCanvasElement, DebugCanvasProps>(
|
|
({ appState, scale }, ref) => {
|
|
const { width, height } = appState;
|
|
|
|
return (
|
|
<canvas
|
|
style={{
|
|
width,
|
|
height,
|
|
position: "absolute",
|
|
zIndex: 2,
|
|
pointerEvents: "none",
|
|
}}
|
|
width={width * scale}
|
|
height={height * scale}
|
|
ref={ref}
|
|
>
|
|
Debug Canvas
|
|
</canvas>
|
|
);
|
|
},
|
|
);
|
|
|
|
export default DebugCanvas;
|