marcel/gamemode
1
0
Fork 0
mirror of https://github.com/FeralInteractive/gamemode.git synced 2025-06-25 08:53:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Default initialise arrays to 0 instead of using memset

Browse Source 
Required moving from global ints to definitions
This commit is contained in:
Marc Di Luzio 2018-01-15 10:54:41 +00:00
parent 0cb31eccbe
commit 1170746a37
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
daemon/cpugovctl.c
View File

@ -34,11 +34,11 @@ POSSIBILITY OF SUCH DAMAGE.
#include <dirent.h> #include <dirent.h>
#include <ctype.h> #include <ctype.h>
static const int max_governors = 128; #define MAX_GOVERNORS 128
static const int max_governor_length = PATH_MAX+1; #define MAX_GOVERNOR_LENGTH PATH_MAX+1
// Governers are located at /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor // Governers are located at /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
static int fetch_governors( char governors[max_governors][max_governor_length] ) static int fetch_governors( char governors[MAX_GOVERNORS][MAX_GOVERNOR_LENGTH] )
{ {
const char* cpu_base_path = "/sys/devices/system/cpu/"; const char* cpu_base_path = "/sys/devices/system/cpu/";
DIR* dir = opendir( cpu_base_path ); DIR* dir = opendir( cpu_base_path );
@ -49,7 +49,7 @@ static int fetch_governors( char governors[max_governors][max_governor_length] )
// Explore the directory // Explore the directory
struct dirent* ent; struct dirent* ent;
while( ( ent = readdir(dir) ) && num_governors < max_governors ) while( ( ent = readdir(dir) ) && num_governors < MAX_GOVERNORS )
{ {
// CPU directories all start with "cpu" // CPU directories all start with "cpu"
if( strncmp( ent->d_name, "cpu", 3 ) == 0 ) if( strncmp( ent->d_name, "cpu", 3 ) == 0 )
@ -74,11 +74,11 @@ static int fetch_governors( char governors[max_governors][max_governor_length] )
// Only add if unique // Only add if unique
for( int i = 0; i < num_governors; i++ ) for( int i = 0; i < num_governors; i++ )
{ {
if( strncmp( fullpath, governors[i], max_governor_length ) == 0 ) if( strncmp( fullpath, governors[i], MAX_GOVERNOR_LENGTH ) == 0 )
continue; continue;
} }
strncpy( governors[num_governors], fullpath, max_governor_length ); strncpy( governors[num_governors], fullpath, MAX_GOVERNOR_LENGTH );
num_governors++; num_governors++;
} }
} }
@ -92,12 +92,10 @@ static int fetch_governors( char governors[max_governors][max_governor_length] )
const char* get_gov_state() const char* get_gov_state()
{ {
// To be returned // To be returned
static char governor[64]; static char governor[64] = {0};
memset( governor, 0, sizeof(governor) );
// State of all the overnors // State of all the overnors
char governors[max_governors][max_governor_length]; char governors[MAX_GOVERNORS][MAX_GOVERNOR_LENGTH] = {{0}};
memset( governors, 0, sizeof(governors) );
int num = fetch_governors( governors ); int num = fetch_governors( governors );
// Check the list // Check the list
@ -147,8 +145,7 @@ const char* get_gov_state()
// Sets all governors to a value // Sets all governors to a value
void set_gov_state( const char* value ) void set_gov_state( const char* value )
{ {
char governors[max_governors][max_governor_length]; char governors[MAX_GOVERNORS][MAX_GOVERNOR_LENGTH] = {{0}};
memset( governors, 0, sizeof(governors) );
int num = fetch_governors( governors ); int num = fetch_governors( governors );
LOG_MSG( "Setting governors to %s\n", value ); LOG_MSG( "Setting governors to %s\n", value );