Update logging to reflect thread, client relationship

This commit is contained in:
Marc Di Luzio 2019-05-12 19:56:20 +01:00
parent bf2b057915
commit 38e48a2d8e

View File

@ -142,7 +142,8 @@ void game_mode_apply_ioprio(const GameModeContext *self, const pid_t client, int
snprintf(tasks, sizeof(tasks), "/proc/%d/task", client); snprintf(tasks, sizeof(tasks), "/proc/%d/task", client);
DIR *client_task_dir = opendir(tasks); DIR *client_task_dir = opendir(tasks);
if (client_task_dir == NULL) { if (client_task_dir == NULL) {
LOG_ERROR("Could not inspect tasks for client %d! Skipping ioprio optimisation.\n", client); LOG_ERROR("Could not inspect tasks for client [%d]! Skipping ioprio optimisation.\n",
client);
return; return;
} }
@ -164,7 +165,8 @@ void game_mode_apply_ioprio(const GameModeContext *self, const pid_t client, int
*/ */
} else if (current != expected) { } else if (current != expected) {
/* Don't try and adjust the ioprio value if the value we got doesn't match default */ /* Don't try and adjust the ioprio value if the value we got doesn't match default */
LOG_ERROR("Refused to set ioprio on client [%d]: prio was (%d) but we expected (%d)\n", LOG_ERROR("Skipping ioprio on client [%d,%d]: ioprio was (%d) but we expected (%d)\n",
client,
tid, tid,
current, current,
expected); expected);
@ -176,8 +178,10 @@ void game_mode_apply_ioprio(const GameModeContext *self, const pid_t client, int
int p = ioprio; int p = ioprio;
ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, ioprio); ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, ioprio);
if (ioprio_set(IOPRIO_WHO_PROCESS, tid, ioprio) != 0) { if (ioprio_set(IOPRIO_WHO_PROCESS, tid, ioprio) != 0) {
/* This could simply mean the thread is gone now, as above */
LOG_ERROR( LOG_ERROR(
"Setting client [%d] IO priority to (%d) failed with error %d, ignoring\n", "Setting client [%d,%d] IO priority to (%d) failed with error %d, ignoring.\n",
client,
tid, tid,
p, p,
errno); errno);