marcel/gamemode
1
0
Fork 0
mirror of https://github.com/FeralInteractive/gamemode.git synced 2025-08-06 05:08:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Minor C cleanup (#27)

Browse Source 
* Minor C cleanup

 - some symbols can be made static:
    1. set_gov_state
    2. everything in gamemode_client.h
 - daemonize() can also take a const char*, since the name is only
   passed to printf() or syslog()
 - prevent shadowing of variables
 - use explicit (void) as parameter-list more consistently
 - use some more const.
   Move cast to more appropriate place and document that execv() behaves
   as if args where of type const *char and we trust on that.
 - example: Just use main(void), which is also an acceptable ISO-C decl
 - example: Use stderr for errors

* Fix -Wold-style-declaration issue
This commit is contained in:
Leonard
2018-04-16 18:21:35 +02:00
committed by Marc Di Luzio
parent 6b71edf740
commit 752d877196
8 changed files with 34 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
daemon/governors.c
View File

@@ -46,7 +46,7 @@ static const char *initial = NULL;
/**
* Cache the governor state as seen at startup
*/
void update_initial_gov_state()
void update_initial_gov_state(void)
{
initial = get_gov_state();
}
@@ -61,9 +61,9 @@ bool set_governors(const char *value)
int ret = 0;
int r = -1;
const char *govern = value ? value : initial;
char *exec_args[] = {
"/usr/bin/pkexec", LIBEXECDIR "/cpugovctl", "set", (char *)govern, NULL,
const char *const govern = value ? value : initial;
const char *const exec_args[] = {
"/usr/bin/pkexec", LIBEXECDIR "/cpugovctl", "set", govern, NULL,
};
LOG_MSG("Requesting update of governor policy to %s\n", govern);
@@ -73,7 +73,13 @@ bool set_governors(const char *value)
return false;
} else if (p == 0) {
/* Execute the command */
if ((r = execv(exec_args[0], exec_args)) != 0) {
/* Note about cast:
* The statement about argv[] and envp[] being constants is
* included to make explicit to future writers of language
* bindings that these objects are completely constant.
* http://pubs.opengroup.org/onlinepubs/9699919799/functions/exec.html
*/
if ((r = execv(exec_args[0], (char *const *)exec_args)) != 0) {
LOG_ERROR("Failed to execute cpugovctl helper: %s %s\n", exec_args[1], strerror(errno));
exit(EXIT_FAILURE);
}
@@ -100,7 +106,7 @@ bool set_governors(const char *value)
/**
* Return the cached governor seen at startup
*/
const char *get_initial_governor()
const char *get_initial_governor(void)
{
return initial;
}