marcel/gamemode
1
0
Fork 0
mirror of https://github.com/FeralInteractive/gamemode.git synced 2025-11-15 05:14:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Minor C cleanup (#27)

Browse Source 
* Minor C cleanup

 - some symbols can be made static:
    1. set_gov_state
    2. everything in gamemode_client.h
 - daemonize() can also take a const char*, since the name is only
   passed to printf() or syslog()
 - prevent shadowing of variables
 - use explicit (void) as parameter-list more consistently
 - use some more const.
   Move cast to more appropriate place and document that execv() behaves
   as if args where of type const *char and we trust on that.
 - example: Just use main(void), which is also an acceptable ISO-C decl
 - example: Use stderr for errors

* Fix -Wold-style-declaration issue
This commit is contained in:
Leonard
2018-04-16 18:21:35 +02:00
committed by Marc Di Luzio
parent 6b71edf740
commit 752d877196
8 changed files with 34 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
example/main.c
View File

@@ -34,11 +34,11 @@ POSSIBILITY OF SUCH DAMAGE.
#include <stdio.h>
#include <unistd.h>
int main(__attribute__((unused)) int argc, __attribute__((unused)) char **argv)
int main(void)
{
/* Request we start game mode */
if (gamemode_request_start() != 0) {
printf("Failed to request gamemode start: %s...\n", gamemode_error_string());
fprintf(stderr, "Failed to request gamemode start: %s...\n", gamemode_error_string());
}
/* Simulate running a game */
@@ -46,6 +46,6 @@ int main(__attribute__((unused)) int argc, __attribute__((unused)) char **argv)
/* Request we end game mode (optional) */
if (gamemode_request_end() != 0) {
printf("Failed to request gamemode end: %s...\n", gamemode_error_string());
fprintf(stderr, "Failed to request gamemode end: %s...\n", gamemode_error_string());
}
}