Ensure that we null terminate the process output buffer in run_external_process

This commit is contained in:
Alex Smith 2019-03-10 10:51:15 +00:00
parent 26ec6ad2b4
commit c49cd45e01

View File

@ -116,11 +116,14 @@ int run_external_process(const char *const *exec_args, char buffer[EXTERNAL_BUFF
} }
close(pipes[1]); close(pipes[1]);
if (read(pipes[0], internal, EXTERNAL_BUFFER_MAX) < 0) { ssize_t output_size = read(pipes[0], internal, EXTERNAL_BUFFER_MAX - 1);
if (output_size < 0) {
LOG_ERROR("Failed to read from process %s: %s\n", exec_args[0], strerror(errno)); LOG_ERROR("Failed to read from process %s: %s\n", exec_args[0], strerror(errno));
return -1; return -1;
} }
internal[output_size] = 0;
if (waitpid(p, &status, 0) < 0) { if (waitpid(p, &status, 0) < 0) {
LOG_ERROR("Failed to waitpid(%d): %s\n", (int)p, strerror(errno)); LOG_ERROR("Failed to waitpid(%d): %s\n", (int)p, strerror(errno));
return -1; return -1;