marcel/gamemode
1
0
Fork 0
mirror of https://github.com/FeralInteractive/gamemode.git synced 2025-08-05 20:58:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Minor C cleanup (#27)

Browse Source 
* Minor C cleanup

 - some symbols can be made static:
    1. set_gov_state
    2. everything in gamemode_client.h
 - daemonize() can also take a const char*, since the name is only
   passed to printf() or syslog()
 - prevent shadowing of variables
 - use explicit (void) as parameter-list more consistently
 - use some more const.
   Move cast to more appropriate place and document that execv() behaves
   as if args where of type const *char and we trust on that.
 - example: Just use main(void), which is also an acceptable ISO-C decl
 - example: Use stderr for errors

* Fix -Wold-style-declaration issue
This commit is contained in:
Leonard
2018-04-16 18:21:35 +02:00
committed by Marc Di Luzio
parent ce64b59381
commit d26ac60da0
8 changed files with 34 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
daemon/governors-query.c
View File

@@ -77,7 +77,7 @@ int fetch_governors(char governors[MAX_GOVERNORS][MAX_GOVERNOR_LENGTH])
}
/* Only add this governor if it is unique */
for (int i = 0; i < num_governors; i++) {
for (int j = 0; j < num_governors; j++) {
if (strncmp(fullpath, governors[i], MAX_GOVERNOR_LENGTH) == 0) {
continue;
}
@@ -95,7 +95,7 @@ int fetch_governors(char governors[MAX_GOVERNORS][MAX_GOVERNOR_LENGTH])
/**
* Return the current governor state
*/
const char *get_gov_state()
const char *get_gov_state(void)
{
/* Cached primary governor state */
static char governor[64] = { 0 };