Update TODO comments

This commit is contained in:
Marc Di Luzio 2019-02-04 17:20:48 +00:00
parent a488af5741
commit db0f8f91f3
2 changed files with 6 additions and 10 deletions

View File

@ -73,8 +73,6 @@ int game_mode_initialise_gpu(GameModeConfig *config, GameModeGPUInfo **info)
config_get_gpu_vendor(config, &new_info->vendor); config_get_gpu_vendor(config, &new_info->vendor);
config_get_gpu_device(config, &new_info->device); config_get_gpu_device(config, &new_info->device);
/* TODO: Detect the GPU vendor and device automatically when these aren't set */
/* verify device ID */ /* verify device ID */
if (new_info->device == -1) { if (new_info->device == -1) {
LOG_ERROR( LOG_ERROR(
@ -202,15 +200,15 @@ int game_mode_apply_gpu(const GameModeGPUInfo *info, bool apply)
char nv_perf_level[4]; char nv_perf_level[4];
snprintf(nv_perf_level, 4, "%ld", info->nv_perf_level); snprintf(nv_perf_level, 4, "%ld", info->nv_perf_level);
// TODO: Actually pass right arguments // Set up our command line to pass to gpuclockctl
const char *const exec_args[] = { const char *const exec_args[] = {
"/usr/bin/pkexec", "/usr/bin/pkexec",
LIBEXECDIR "/gpuclockctl", LIBEXECDIR "/gpuclockctl",
vendor, vendor,
device, device,
"set", "set",
apply ? core : "0", /* For now simply reset to zero */ apply ? core : "0",
apply ? mem : "0", /* could in the future store default values for reset */ apply ? mem : "0",
info->vendor == Vendor_NVIDIA ? nv_perf_level : NULL, /* Only use this if Nvidia */ info->vendor == Vendor_NVIDIA ? nv_perf_level : NULL, /* Only use this if Nvidia */
NULL, NULL,
}; };

View File

@ -37,11 +37,9 @@ POSSIBILITY OF SUCH DAMAGE.
#include "gpu-control.h" #include "gpu-control.h"
// TODO // TODO
// Apply Nvidia GPU settings (CoolBits will be needed) // Intel support - https://blog.ffwll.ch/2013/03/overclocking-your-intel-gpu-on-linux.html
// Apply AMD GPU settings (Will need user changing pwm1_enable) // AMD - Allow setting fan speed as well
// Provide documentation on optimisations // Store baseline values with get_gpu_state to apply when leaving gamemode
// Intel?
// Gather GPU type and information automatically if possible
/* Helper to quit with usage */ /* Helper to quit with usage */
static const char *usage_text = static const char *usage_text =