marcel/linkding
1
0
Fork 0
mirror of https://github.com/sissbruecker/linkding.git synced 2025-11-20 13:04:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add new search engine that supports logical expressions (and, or, not) (#1198)

Browse Source 
* parser implementation

* add support for quoted strings

* add support for tags

* ignore empty tags

* implicit and

* prepare query conversion by disabling tests

* convert query logic

* fix nested combined tag searches

* simplify query logic

* Add special keyword support to parser

* Add special keyword support to query builder

* Handle invalid queries in query builder

* Notify user about invalid queries

* Add helper to strip tags from search query

* Make tag cloud show all tags from search query

* Use new method for extracting tags

* Add query for getting tags from search query

* Get selected tags through specific context

* Properly remove selected tags from complex queries

* cleanup

* Clarify bundle search terms

* Add documentation draft

* Improve adding tags to search query

* Add option to switch back to the old search
This commit is contained in:
Sascha Ißbrücker
2025-10-05 12:51:08 +02:00
committed by GitHub
parent 229d3b511f
commit 051bd39256
22 changed files with 2831 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
bookmarks/tests/test_bookmarks_list_template.py
View File

@@ -476,6 +476,27 @@ class BookmarkListTemplateTest(TestCase, BookmarkFactoryMixin, HtmlTestMixin):
self.assertEqual(tag_links[1].text, "#tag2")
self.assertEqual(tag_links[2].text, "#tag3")
def test_bookmark_tag_query_string(self):
# appends tag to existing query string
bookmark = self.setup_bookmark(title="term1 term2")
tag1 = self.setup_tag(name="tag1")
bookmark.tags.add(tag1)
html = self.render_template(url="/bookmarks?q=term1 and term2")
soup = self.make_soup(html)
tags = soup.select_one(".tags")
tag_links = tags.find_all("a")
self.assertEqual(len(tag_links), 1)
self.assertEqual(tag_links[0]["href"], "?q=term1+and+term2+%23tag1")
# wraps or expression in parentheses
html = self.render_template(url="/bookmarks?q=term1 or term2")
soup = self.make_soup(html)
tags = soup.select_one(".tags")
tag_links = tags.find_all("a")
self.assertEqual(len(tag_links), 1)
self.assertEqual(tag_links[0]["href"], "?q=%28term1+or+term2%29+%23tag1")
def test_should_render_web_archive_link_with_absolute_date_setting(self):
bookmark = self.setup_date_format_test(
UserProfile.BOOKMARK_DATE_DISPLAY_ABSOLUTE,
@@ -1017,6 +1038,34 @@ class BookmarkListTemplateTest(TestCase, BookmarkFactoryMixin, HtmlTestMixin):
'<p class="empty-title h5">You have no bookmarks yet</p>', html
)
def test_empty_state_with_valid_query_no_results(self):
self.setup_bookmark(title="Test Bookmark")
html = self.render_template(url="/bookmarks?q=nonexistent")
self.assertInHTML(
'<p class="empty-title h5">You have no bookmarks yet</p>', html
)
def test_empty_state_with_invalid_query(self):
self.setup_bookmark()
html = self.render_template(url="/bookmarks?q=(test")
self.assertInHTML('<p class="empty-title h5">Invalid search query</p>', html)
self.assertIn("Expected RPAREN", html)
def test_empty_state_with_legacy_search(self):
profile = self.get_or_create_test_user().profile
profile.legacy_search = True
profile.save()
self.setup_bookmark()
html = self.render_template(url="/bookmarks?q=(test")
# With legacy search, search queries are not validated
self.assertInHTML(
'<p class="empty-title h5">You have no bookmarks yet</p>', html
)
def test_pagination_is_not_sticky_by_default(self):
self.setup_bookmark()
html = self.render_template()