marcel/linkding
1
0
Fork 0
mirror of https://github.com/sissbruecker/linkding.git synced 2025-09-09 18:49:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Normalize URLs when checking for duplicates (#1169)

Browse Source 
* Normalize URLs when checking for duplicates

* Improve migration script
This commit is contained in:
Sascha Ißbrücker
2025-08-22 19:37:28 +02:00
committed by GitHub
parent 96176ba50e
commit 723b843c13
11 changed files with 381 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bookmarks/forms.py
View File

@@ -5,6 +5,7 @@ from bookmarks.models import Bookmark, build_tag_string
from bookmarks.validators import BookmarkURLValidator
from bookmarks.type_defs import HttpRequest
from bookmarks.services.bookmarks import create_bookmark, update_bookmark
from bookmarks.utils import normalize_url
class CustomErrorList(ErrorList):
@@ -85,8 +86,11 @@ class BookmarkForm(forms.ModelForm):
# raise a validation error in that case.
url = self.cleaned_data["url"]
if self.instance.pk:
normalized_url = normalize_url(url)
is_duplicate = (
Bookmark.objects.filter(owner=self.instance.owner, url=url)
Bookmark.objects.filter(
owner=self.instance.owner, url_normalized=normalized_url
)
.exclude(pk=self.instance.pk)
.exists()
)