Check for dupes by exact URL if normalized URL is missing (#1204)

This commit is contained in:
Sascha Ißbrücker
2025-10-11 10:45:23 +02:00
committed by GitHub
parent a6b36750da
commit 95529eccd4
5 changed files with 58 additions and 19 deletions

View File

@@ -11,7 +11,6 @@ from bookmarks.models import (
)
from bookmarks.services.bookmarks import create_bookmark, update_bookmark
from bookmarks.type_defs import HttpRequest
from bookmarks.utils import normalize_url
from bookmarks.validators import BookmarkURLValidator
@@ -94,11 +93,8 @@ class BookmarkForm(forms.ModelForm):
# raise a validation error in that case.
url = self.cleaned_data["url"]
if self.instance.pk:
normalized_url = normalize_url(url)
is_duplicate = (
Bookmark.objects.filter(
owner=self.instance.owner, url_normalized=normalized_url
)
Bookmark.query_existing(self.instance.owner, url)
.exclude(pk=self.instance.pk)
.exists()
)