From dcb15f19429ffc6018b1ee7cfe11c08b0c959066 Mon Sep 17 00:00:00 2001 From: m3e <174959531+m3eno@users.noreply.github.com> Date: Sat, 18 Oct 2025 06:24:31 +0200 Subject: [PATCH] Fix devcontainer (#1208) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update Python version to 3.13 in devcontainer * Update `postCreateCommand` to install and use uv * Update DevContainers paragraph in README with uv commands * Update commands --------- Co-authored-by: Sascha Ißbrücker --- .devcontainer/devcontainer.json | 4 ++-- README.md | 11 +++-------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 7c2a3d1..0638d3f 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -2,7 +2,7 @@ // README at: https://github.com/devcontainers/templates/tree/main/src/python { "name": "Python 3", - "image": "mcr.microsoft.com/devcontainers/python:3.12", + "image": "mcr.microsoft.com/devcontainers/python:3.13", "features": { "ghcr.io/devcontainers/features/node:1": {} }, @@ -14,7 +14,7 @@ "forwardPorts": [8000], // Use 'postCreateCommand' to run commands after the container is created. - "postCreateCommand": "pip3 install --user -r requirements.txt -r requirements.dev.txt && npm install && mkdir -p data && python3 manage.py migrate", + "postCreateCommand": "pip install uv && uv sync --group dev && npm install && mkdir -p data && uv run manage.py migrate", // Configure tool-specific properties. "customizations": { diff --git a/README.md b/README.md index 6788c5a..085377a 100644 --- a/README.md +++ b/README.md @@ -105,25 +105,20 @@ make format ### DevContainers -> [!WARNING] -> The dev container setup is currently broken after switching to uv. -> Feel free to contribute a PR if you want to fix it. -> The instructions below are outdated until then. - This repository also supports DevContainers: [![Open in Remote - Containers](https://img.shields.io/static/v1?label=Remote%20-%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/sissbruecker/linkding.git) Once checked out, only the following commands are required to get started: Create a user for the frontend: ``` -python3 manage.py createsuperuser --username=joe --email=joe@example.com +uv run manage.py createsuperuser --username=joe --email=joe@example.com ``` Start the Node.js development server (used for compiling JavaScript components like tag auto-completion) with: ``` -npm run dev +make frontend ``` Start the Django development server with: ``` -python3 manage.py runserver +make serve ``` The frontend is now available under http://localhost:8000