From f1acb4f7c969b69a441da0c043fe5bbe6dbc3748 Mon Sep 17 00:00:00 2001 From: Jose Alvarez Date: Sat, 22 Mar 2025 03:27:35 -0400 Subject: [PATCH] Handle lowercase "true" in environment variables (#1020) --- bookmarks/settings/base.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/bookmarks/settings/base.py b/bookmarks/settings/base.py index a5ded9e..559ef8d 100644 --- a/bookmarks/settings/base.py +++ b/bookmarks/settings/base.py @@ -146,6 +146,7 @@ ALLOW_REGISTRATION = False LD_DISABLE_URL_VALIDATION = os.getenv("LD_DISABLE_URL_VALIDATION", False) in ( True, "True", + "true", "1", ) @@ -153,6 +154,7 @@ LD_DISABLE_URL_VALIDATION = os.getenv("LD_DISABLE_URL_VALIDATION", False) in ( LD_DISABLE_BACKGROUND_TASKS = os.getenv("LD_DISABLE_BACKGROUND_TASKS", False) in ( True, "True", + "true", "1", ) @@ -179,7 +181,7 @@ HUEY = { # Enable OICD support if configured -LD_ENABLE_OIDC = os.getenv("LD_ENABLE_OIDC", False) in (True, "True", "1") +LD_ENABLE_OIDC = os.getenv("LD_ENABLE_OIDC", False) in (True, "True", "true", "1") AUTHENTICATION_BACKENDS = ["django.contrib.auth.backends.ModelBackend"] @@ -195,12 +197,17 @@ if LD_ENABLE_OIDC: OIDC_RP_CLIENT_SECRET = os.getenv("OIDC_RP_CLIENT_SECRET") OIDC_RP_SIGN_ALGO = os.getenv("OIDC_RP_SIGN_ALGO", "RS256") OIDC_RP_SCOPES = os.getenv("OIDC_RP_SCOPES", "openid email profile") - OIDC_USE_PKCE = os.getenv("OIDC_USE_PKCE", True) in (True, "True", "1") - OIDC_VERIFY_SSL = os.getenv("OIDC_VERIFY_SSL", True) in (True, "True", "1") + OIDC_USE_PKCE = os.getenv("OIDC_USE_PKCE", True) in (True, "True", "true", "1") + OIDC_VERIFY_SSL = os.getenv("OIDC_VERIFY_SSL", True) in (True, "True", "true", "1") OIDC_USERNAME_CLAIM = os.getenv("OIDC_USERNAME_CLAIM", "email") # Enable authentication proxy support if configured -LD_ENABLE_AUTH_PROXY = os.getenv("LD_ENABLE_AUTH_PROXY", False) in (True, "True", "1") +LD_ENABLE_AUTH_PROXY = os.getenv("LD_ENABLE_AUTH_PROXY", False) in ( + True, + "True", + "true", + "1", +) LD_AUTH_PROXY_USERNAME_HEADER = os.getenv( "LD_AUTH_PROXY_USERNAME_HEADER", "REMOTE_USER" ) @@ -267,6 +274,7 @@ LD_FAVICON_FOLDER = os.path.join(BASE_DIR, "data", "favicons") LD_ENABLE_REFRESH_FAVICONS = os.getenv("LD_ENABLE_REFRESH_FAVICONS", True) in ( True, "True", + "true", "1", ) @@ -288,11 +296,13 @@ LD_ASSET_FOLDER = os.path.join(BASE_DIR, "data", "assets") LD_ENABLE_SNAPSHOTS = os.getenv("LD_ENABLE_SNAPSHOTS", False) in ( True, "True", + "true", "1", ) LD_DISABLE_ASSET_UPLOAD = os.getenv("LD_DISABLE_ASSET_UPLOAD", False) in ( True, "True", + "true", "1", ) LD_SINGLEFILE_PATH = os.getenv("LD_SINGLEFILE_PATH", "single-file")