mirror of
https://github.com/sissbruecker/linkding.git
synced 2025-08-07 10:58:25 +02:00
1672dc0152
* add bundle model and query logic * cleanup tests * add basic form * add success message * Add form tests * Add bundle list view * fix edit view * Add remove button * Add basic preview logic * Make pagination use absolute URLs * Hide bookmark edits when rendering preview * Render bookmark list in preview * Reorder bundles * Show bundles in bookmark view * Make bookmark search respect selected bundle * UI tweaks * Fix bookmark scope * Improve bundle preview * Skip preview if form is submitted * Show correct preview after invalid form submission * Add option to hide bundles * Merge new migrations * Add tests for bundle menu * Improve check for preview being removed
304 lines
11 KiB
Python
304 lines
11 KiB
Python
from django.http import QueryDict
|
|
from django.test import TestCase
|
|
|
|
from bookmarks.models import BookmarkSearch
|
|
from bookmarks.tests.helpers import BookmarkFactoryMixin
|
|
|
|
|
|
class MockRequest:
|
|
def __init__(self, user):
|
|
self.user = user
|
|
|
|
|
|
class BookmarkSearchModelTest(TestCase, BookmarkFactoryMixin):
|
|
def test_from_request(self):
|
|
# no params
|
|
query_dict = QueryDict()
|
|
|
|
search = BookmarkSearch.from_request(None, query_dict)
|
|
self.assertEqual(search.q, "")
|
|
self.assertEqual(search.user, "")
|
|
self.assertEqual(search.bundle, None)
|
|
self.assertEqual(search.sort, BookmarkSearch.SORT_ADDED_DESC)
|
|
self.assertEqual(search.shared, BookmarkSearch.FILTER_SHARED_OFF)
|
|
self.assertEqual(search.unread, BookmarkSearch.FILTER_UNREAD_OFF)
|
|
|
|
# some params
|
|
query_dict = QueryDict("q=search query&user=user123")
|
|
|
|
bookmark_search = BookmarkSearch.from_request(None, query_dict)
|
|
self.assertEqual(bookmark_search.q, "search query")
|
|
self.assertEqual(bookmark_search.user, "user123")
|
|
self.assertEqual(bookmark_search.sort, BookmarkSearch.SORT_ADDED_DESC)
|
|
self.assertEqual(search.shared, BookmarkSearch.FILTER_SHARED_OFF)
|
|
self.assertEqual(search.unread, BookmarkSearch.FILTER_UNREAD_OFF)
|
|
|
|
# all params
|
|
bundle = self.setup_bundle()
|
|
request = MockRequest(self.get_or_create_test_user())
|
|
query_dict = QueryDict(
|
|
f"q=search query&sort=title_asc&user=user123&bundle={bundle.id}&shared=yes&unread=yes"
|
|
)
|
|
|
|
search = BookmarkSearch.from_request(request, query_dict)
|
|
self.assertEqual(search.q, "search query")
|
|
self.assertEqual(search.user, "user123")
|
|
self.assertEqual(search.bundle, bundle)
|
|
self.assertEqual(search.sort, BookmarkSearch.SORT_TITLE_ASC)
|
|
self.assertEqual(search.shared, BookmarkSearch.FILTER_SHARED_SHARED)
|
|
self.assertEqual(search.unread, BookmarkSearch.FILTER_UNREAD_YES)
|
|
|
|
# respects preferences
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
query_dict = QueryDict("q=search query")
|
|
|
|
search = BookmarkSearch.from_request(None, query_dict, preferences)
|
|
self.assertEqual(search.q, "search query")
|
|
self.assertEqual(search.user, "")
|
|
self.assertEqual(search.sort, BookmarkSearch.SORT_TITLE_ASC)
|
|
self.assertEqual(search.shared, BookmarkSearch.FILTER_SHARED_OFF)
|
|
self.assertEqual(search.unread, BookmarkSearch.FILTER_UNREAD_YES)
|
|
|
|
# query overrides preferences
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_SHARED,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
query_dict = QueryDict("sort=title_desc&shared=no&unread=off")
|
|
|
|
search = BookmarkSearch.from_request(None, query_dict, preferences)
|
|
self.assertEqual(search.q, "")
|
|
self.assertEqual(search.user, "")
|
|
self.assertEqual(search.sort, BookmarkSearch.SORT_TITLE_DESC)
|
|
self.assertEqual(search.shared, BookmarkSearch.FILTER_SHARED_UNSHARED)
|
|
self.assertEqual(search.unread, BookmarkSearch.FILTER_UNREAD_OFF)
|
|
|
|
def test_from_request_ignores_invalid_bundle_param(self):
|
|
self.setup_bundle()
|
|
|
|
# bundle does not exist
|
|
request = MockRequest(self.get_or_create_test_user())
|
|
query_dict = QueryDict("bundle=99999")
|
|
search = BookmarkSearch.from_request(request, query_dict)
|
|
self.assertIsNone(search.bundle)
|
|
|
|
# bundle belongs to another user
|
|
other_user = self.setup_user()
|
|
bundle = self.setup_bundle(user=other_user)
|
|
query_dict = QueryDict(f"bundle={bundle.id}")
|
|
search = BookmarkSearch.from_request(request, query_dict)
|
|
self.assertIsNone(search.bundle)
|
|
|
|
def test_query_params(self):
|
|
# no params
|
|
search = BookmarkSearch()
|
|
self.assertEqual(search.query_params, {})
|
|
|
|
# params are default values
|
|
search = BookmarkSearch(
|
|
q="", sort=BookmarkSearch.SORT_ADDED_DESC, user="", bundle=None, shared=""
|
|
)
|
|
self.assertEqual(search.query_params, {})
|
|
|
|
# some modified params
|
|
search = BookmarkSearch(q="search query", sort=BookmarkSearch.SORT_ADDED_ASC)
|
|
self.assertEqual(
|
|
search.query_params,
|
|
{"q": "search query", "sort": BookmarkSearch.SORT_ADDED_ASC},
|
|
)
|
|
|
|
# all modified params
|
|
bundle = self.setup_bundle()
|
|
search = BookmarkSearch(
|
|
q="search query",
|
|
sort=BookmarkSearch.SORT_ADDED_ASC,
|
|
user="user123",
|
|
bundle=bundle,
|
|
shared=BookmarkSearch.FILTER_SHARED_SHARED,
|
|
unread=BookmarkSearch.FILTER_UNREAD_YES,
|
|
)
|
|
self.assertEqual(
|
|
search.query_params,
|
|
{
|
|
"q": "search query",
|
|
"sort": BookmarkSearch.SORT_ADDED_ASC,
|
|
"user": "user123",
|
|
"bundle": bundle.id,
|
|
"shared": BookmarkSearch.FILTER_SHARED_SHARED,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
},
|
|
)
|
|
|
|
# preferences are not query params if they match default
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
search = BookmarkSearch(preferences=preferences)
|
|
self.assertEqual(search.query_params, {})
|
|
|
|
# param is not a query param if it matches the preference
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
search = BookmarkSearch(
|
|
sort=BookmarkSearch.SORT_TITLE_ASC,
|
|
unread=BookmarkSearch.FILTER_UNREAD_YES,
|
|
preferences=preferences,
|
|
)
|
|
self.assertEqual(search.query_params, {})
|
|
|
|
# overriding preferences is a query param
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_SHARED,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
search = BookmarkSearch(
|
|
sort=BookmarkSearch.SORT_TITLE_DESC,
|
|
shared=BookmarkSearch.FILTER_SHARED_UNSHARED,
|
|
unread=BookmarkSearch.FILTER_UNREAD_OFF,
|
|
preferences=preferences,
|
|
)
|
|
self.assertEqual(
|
|
search.query_params,
|
|
{
|
|
"sort": BookmarkSearch.SORT_TITLE_DESC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_UNSHARED,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_OFF,
|
|
},
|
|
)
|
|
|
|
def test_modified_params(self):
|
|
# no params
|
|
bookmark_search = BookmarkSearch()
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertEqual(len(modified_params), 0)
|
|
|
|
# params are default values
|
|
bookmark_search = BookmarkSearch(
|
|
q="", sort=BookmarkSearch.SORT_ADDED_DESC, user="", shared=""
|
|
)
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertEqual(len(modified_params), 0)
|
|
|
|
# some modified params
|
|
bookmark_search = BookmarkSearch(
|
|
q="search query", sort=BookmarkSearch.SORT_ADDED_ASC
|
|
)
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertCountEqual(modified_params, ["q", "sort"])
|
|
|
|
# all modified params
|
|
bundle = self.setup_bundle()
|
|
bookmark_search = BookmarkSearch(
|
|
q="search query",
|
|
sort=BookmarkSearch.SORT_ADDED_ASC,
|
|
user="user123",
|
|
bundle=bundle,
|
|
shared=BookmarkSearch.FILTER_SHARED_SHARED,
|
|
unread=BookmarkSearch.FILTER_UNREAD_YES,
|
|
)
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertCountEqual(
|
|
modified_params, ["q", "sort", "user", "bundle", "shared", "unread"]
|
|
)
|
|
|
|
# preferences are not modified params
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
bookmark_search = BookmarkSearch(preferences=preferences)
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertEqual(len(modified_params), 0)
|
|
|
|
# param is not modified if it matches the preference
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
bookmark_search = BookmarkSearch(
|
|
sort=BookmarkSearch.SORT_TITLE_ASC,
|
|
unread=BookmarkSearch.FILTER_UNREAD_YES,
|
|
preferences=preferences,
|
|
)
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertEqual(len(modified_params), 0)
|
|
|
|
# overriding preferences is a modified param
|
|
preferences = {
|
|
"sort": BookmarkSearch.SORT_TITLE_ASC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_SHARED,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
}
|
|
bookmark_search = BookmarkSearch(
|
|
sort=BookmarkSearch.SORT_TITLE_DESC,
|
|
shared=BookmarkSearch.FILTER_SHARED_UNSHARED,
|
|
unread=BookmarkSearch.FILTER_UNREAD_OFF,
|
|
preferences=preferences,
|
|
)
|
|
modified_params = bookmark_search.modified_params
|
|
self.assertCountEqual(modified_params, ["sort", "shared", "unread"])
|
|
|
|
def test_has_modifications(self):
|
|
# no params
|
|
bookmark_search = BookmarkSearch()
|
|
self.assertFalse(bookmark_search.has_modifications)
|
|
|
|
# params are default values
|
|
bookmark_search = BookmarkSearch(
|
|
q="", sort=BookmarkSearch.SORT_ADDED_DESC, user="", shared=""
|
|
)
|
|
self.assertFalse(bookmark_search.has_modifications)
|
|
|
|
# modified params
|
|
bookmark_search = BookmarkSearch(
|
|
q="search query", sort=BookmarkSearch.SORT_ADDED_ASC
|
|
)
|
|
self.assertTrue(bookmark_search.has_modifications)
|
|
|
|
def test_preferences_dict(self):
|
|
# no params
|
|
bookmark_search = BookmarkSearch()
|
|
self.assertEqual(
|
|
bookmark_search.preferences_dict,
|
|
{
|
|
"sort": BookmarkSearch.SORT_ADDED_DESC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_OFF,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_OFF,
|
|
},
|
|
)
|
|
|
|
# with params
|
|
bookmark_search = BookmarkSearch(
|
|
sort=BookmarkSearch.SORT_TITLE_DESC, unread=BookmarkSearch.FILTER_UNREAD_YES
|
|
)
|
|
self.assertEqual(
|
|
bookmark_search.preferences_dict,
|
|
{
|
|
"sort": BookmarkSearch.SORT_TITLE_DESC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_OFF,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_YES,
|
|
},
|
|
)
|
|
|
|
# only returns preferences
|
|
bundle = self.setup_bundle()
|
|
bookmark_search = BookmarkSearch(
|
|
q="search query", user="user123", bundle=bundle
|
|
)
|
|
self.assertEqual(
|
|
bookmark_search.preferences_dict,
|
|
{
|
|
"sort": BookmarkSearch.SORT_ADDED_DESC,
|
|
"shared": BookmarkSearch.FILTER_SHARED_OFF,
|
|
"unread": BookmarkSearch.FILTER_UNREAD_OFF,
|
|
},
|
|
)
|