From 7f5160fa4de961bf606264b0614fe810af2fd2d0 Mon Sep 17 00:00:00 2001 From: Sidharth Vinod Date: Tue, 4 Nov 2025 21:12:10 +0700 Subject: [PATCH 1/3] chore: Remove NPM_TOKEN from release workflow --- .github/workflows/release.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7dbf85d94..ece84ac20 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -42,5 +42,4 @@ jobs: publish: pnpm changeset:publish env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - NPM_TOKEN: ${{ secrets.NPM_TOKEN }} NPM_CONFIG_PROVENANCE: true From 287a9a3fcb89ec379fae287f3564daf4f799fef3 Mon Sep 17 00:00:00 2001 From: Sidharth Vinod Date: Tue, 4 Nov 2025 21:21:58 +0700 Subject: [PATCH 2/3] chore: Add missing clean scripts Co-authored-by: Alois Klink --- packages/mermaid-layout-elk/package.json | 4 +++- packages/mermaid-layout-tidy-tree/package.json | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/mermaid-layout-elk/package.json b/packages/mermaid-layout-elk/package.json index 91c1ae81f..e47d64edf 100644 --- a/packages/mermaid-layout-elk/package.json +++ b/packages/mermaid-layout-elk/package.json @@ -18,7 +18,9 @@ "elk", "mermaid" ], - "scripts": {}, + "scripts": { + "clean": "rimraf dist" + }, "repository": { "type": "git", "url": "https://github.com/mermaid-js/mermaid" diff --git a/packages/mermaid-layout-tidy-tree/package.json b/packages/mermaid-layout-tidy-tree/package.json index bdc15869f..2abaaa211 100644 --- a/packages/mermaid-layout-tidy-tree/package.json +++ b/packages/mermaid-layout-tidy-tree/package.json @@ -19,7 +19,9 @@ "mermaid", "layout" ], - "scripts": {}, + "scripts": { + "clean": "rimraf dist" + }, "repository": { "type": "git", "url": "https://github.com/mermaid-js/mermaid" From 6546aed482f7210e18b19f198f0c5284119e6148 Mon Sep 17 00:00:00 2001 From: Sidharth Vinod Date: Wed, 5 Nov 2025 00:07:30 +0700 Subject: [PATCH 3/3] chore: forbid use of `viewbox` in code --- .cspell/code-terms.txt | 2 ++ cypress/helpers/util.ts | 1 + 2 files changed, 3 insertions(+) diff --git a/.cspell/code-terms.txt b/.cspell/code-terms.txt index 8b549f888..5f72ea221 100644 --- a/.cspell/code-terms.txt +++ b/.cspell/code-terms.txt @@ -1,3 +1,5 @@ +!viewbox +# It should be viewBox # This file contains coding related terms ALPHANUM antiscript diff --git a/cypress/helpers/util.ts b/cypress/helpers/util.ts index d02e9da87..0332178f6 100644 --- a/cypress/helpers/util.ts +++ b/cypress/helpers/util.ts @@ -99,6 +99,7 @@ export const openURLAndVerifyRendering = ( cy.visit(url); cy.window().should('have.property', 'rendered', true); cy.get('svg').should('be.visible'); + // cspell:ignore viewbox cy.get('svg').should('not.have.attr', 'viewbox'); if (validation) {