diff --git a/src/diagrams/git/gitGraphAst.js b/src/diagrams/git/gitGraphAst.js index 2e7dc601a..eefb84ad5 100644 --- a/src/diagrams/git/gitGraphAst.js +++ b/src/diagrams/git/gitGraphAst.js @@ -148,7 +148,7 @@ export const branch = function (name, order) { } }; -export const merge = function (otherBranch, tag) { +export const merge = function (otherBranch, custom_id, override_type, custom_tag) { otherBranch = common.sanitizeText(otherBranch, configApi.getConfig()); const currentCommit = commits[branches[curBranch]]; const otherCommit = commits[branches[otherBranch]]; @@ -207,6 +207,23 @@ export const merge = function (otherBranch, tag) { loc: { first_line: 1, last_line: 1, first_column: 1, last_column: 1 }, expected: ['branch abc'], }; + throw error; + } else if (custom_id && typeof commits[custom_id] !== 'undefined') { + let error = new Error( + 'Incorrect usage of "merge". Commit with id:' + + custom_id + + ' already exists, use different custom Id' + ); + error.hash = { + text: 'merge ' + otherBranch + custom_id + override_type + custom_tag, + token: 'merge ' + otherBranch + custom_id + override_type + custom_tag, + line: '1', + loc: { first_line: 1, last_line: 1, first_column: 1, last_column: 1 }, + expected: [ + 'merge ' + otherBranch + ' ' + custom_id + '_UNIQUE ' + override_type + ' ' + custom_tag, + ], + }; + throw error; } // if (isReachableFrom(currentCommit, otherCommit)) { @@ -219,13 +236,15 @@ export const merge = function (otherBranch, tag) { // } else { // create merge commit const commit = { - id: seq + '-' + getId(), + id: custom_id ? custom_id : seq + '-' + getId(), message: 'merged branch ' + otherBranch + ' into ' + curBranch, seq: seq++, parents: [head == null ? null : head.id, branches[otherBranch]], branch: curBranch, type: commitType.MERGE, - tag: tag ? tag : '', + customType: override_type, + customId: custom_id ? true : false, + tag: custom_tag ? custom_tag : '', }; head = commit; commits[commit.id] = commit; diff --git a/src/diagrams/git/gitGraphRenderer.js b/src/diagrams/git/gitGraphRenderer.js index 0a7c457cf..73588fa2d 100644 --- a/src/diagrams/git/gitGraphRenderer.js +++ b/src/diagrams/git/gitGraphRenderer.js @@ -91,7 +91,9 @@ const drawCommits = (svg, commits, modifyGraph) => { // Don't draw the commits now but calculate the positioning which is used by the branch lines etc. if (modifyGraph) { let typeClass; - switch (commit.type) { + let commitSymbolType = + typeof commit.customType !== 'undefined' ? commit.customType : commit.type; + switch (commitSymbolType) { case commitType.NORMAL: typeClass = 'commit-normal'; break; @@ -111,7 +113,7 @@ const drawCommits = (svg, commits, modifyGraph) => { typeClass = 'commit-normal'; } - if (commit.type === commitType.HIGHLIGHT) { + if (commitSymbolType === commitType.HIGHLIGHT) { const circle = gBullets.append('rect'); circle.attr('x', x - 10); circle.attr('y', y - 10); @@ -135,7 +137,7 @@ const drawCommits = (svg, commits, modifyGraph) => { branchPos[commit.branch].index % THEME_COLOR_LIMIT } ${typeClass}-inner` ); - } else if (commit.type === commitType.CHERRY_PICK) { + } else if (commitSymbolType === commitType.CHERRY_PICK) { gBullets .append('circle') .attr('cx', x) @@ -181,7 +183,7 @@ const drawCommits = (svg, commits, modifyGraph) => { 'class', `commit ${commit.id} commit${branchPos[commit.branch].index % THEME_COLOR_LIMIT}` ); - if (commit.type === commitType.MERGE) { + if (commitSymbolType === commitType.MERGE) { const circle2 = gBullets.append('circle'); circle2.attr('cx', x); circle2.attr('cy', y); @@ -193,7 +195,7 @@ const drawCommits = (svg, commits, modifyGraph) => { }` ); } - if (commit.type === commitType.REVERSE) { + if (commitSymbolType === commitType.REVERSE) { const cross = gBullets.append('path'); cross .attr('d', `M ${x - 5},${y - 5}L${x + 5},${y + 5}M${x - 5},${y + 5}L${x + 5},${y - 5}`) @@ -217,7 +219,8 @@ const drawCommits = (svg, commits, modifyGraph) => { // Draw the commit label if ( commit.type !== commitType.CHERRY_PICK && - commit.type !== commitType.MERGE && + ((commit.customId && commit.type === commitType.MERGE) || + commit.type !== commitType.MERGE) && gitGraphConfig.showCommitLabel ) { const wrapper = gLabels.append('g'); diff --git a/src/diagrams/git/parser/gitGraph.jison b/src/diagrams/git/parser/gitGraph.jison index 04b208249..937a7192a 100644 --- a/src/diagrams/git/parser/gitGraph.jison +++ b/src/diagrams/git/parser/gitGraph.jison @@ -121,8 +121,22 @@ cherryPickStatement ; mergeStatement - : MERGE ID {yy.merge($2)} - | MERGE ID COMMIT_TAG STR {yy.merge($2, $4)} + : MERGE ID {yy.merge($2,'','','')} + | MERGE ID COMMIT_ID STR {yy.merge($2, $4,'','')} + | MERGE ID COMMIT_TYPE commitType {yy.merge($2,'', $4,'')} + | MERGE ID COMMIT_TAG STR {yy.merge($2, '','',$4)} + | MERGE ID COMMIT_TAG STR COMMIT_ID STR {yy.merge($2, $6,'', $4)} + | MERGE ID COMMIT_TAG STR COMMIT_TYPE commitType {yy.merge($2, '',$6, $4)} + | MERGE ID COMMIT_TYPE commitType COMMIT_TAG STR {yy.merge($2, '',$4, $6)} + | MERGE ID COMMIT_ID STR COMMIT_TYPE commitType {yy.merge($2, $4, $6, '')} + | MERGE ID COMMIT_ID STR COMMIT_TAG STR {yy.merge($2, $4, '', $6)} + | MERGE ID COMMIT_TYPE commitType COMMIT_ID STR {yy.merge($2, $6,$4, '')} + | MERGE ID COMMIT_ID STR COMMIT_TYPE commitType COMMIT_TAG STR {yy.merge($2, $4, $6, $8)} + | MERGE ID COMMIT_TYPE commitType COMMIT_TAG STR COMMIT_ID STR {yy.merge($2, $8, $4, $6)} + | MERGE ID COMMIT_ID STR COMMIT_TAG STR COMMIT_TYPE commitType {yy.merge($2, $4, $8, $6)} + | MERGE ID COMMIT_TYPE commitType COMMIT_ID STR COMMIT_TAG STR {yy.merge($2, $6, $4, $8)} + | MERGE ID COMMIT_TAG STR COMMIT_TYPE commitType COMMIT_ID STR {yy.merge($2, $8, $6, $4)} + | MERGE ID COMMIT_TAG STR COMMIT_ID STR COMMIT_TYPE commitType {yy.merge($2, $6, $8, $4)} ; commitStatement