From 3381717e868fc1fd20a7ee2d4acdce6690ce0710 Mon Sep 17 00:00:00 2001
From: Sidharth Vinod <sidharthv96@gmail.com>
Date: Fri, 21 Jun 2024 11:55:05 +0530
Subject: [PATCH] chore: Biome fix for-of loops

---
 biome.json                                           |  2 +-
 .../src/diagrams/flowchart/flowRenderer-v2.js        |  6 +++---
 .../mermaid/src/diagrams/flowchart/flowRenderer.js   | 12 ++++++------
 .../mermaid/src/diagrams/state/stateRenderer-v2.js   |  3 +--
 .../src/diagrams/timeline/timelineRenderer.ts        |  3 +--
 5 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/biome.json b/biome.json
index d21b39e68..d7238b713 100644
--- a/biome.json
+++ b/biome.json
@@ -72,7 +72,7 @@
         "noNamespace": "error",
         "useAsConstAssertion": "error",
         "useBlockStatements": "error",
-        "useForOf": "warn",
+        "useForOf": "error",
         "useImportType": "error",
         "useNamingConvention": {
           "level": "off",
diff --git a/packages/mermaid/src/diagrams/flowchart/flowRenderer-v2.js b/packages/mermaid/src/diagrams/flowchart/flowRenderer-v2.js
index 824274ec6..760196019 100644
--- a/packages/mermaid/src/diagrams/flowchart/flowRenderer-v2.js
+++ b/packages/mermaid/src/diagrams/flowchart/flowRenderer-v2.js
@@ -427,9 +427,9 @@ export const draw = async function (text, id, _version, diagObj) {
 
     selectAll('cluster').append('text');
 
-    for (let j = 0; j < subG.nodes.length; j++) {
-      log.info('Setting up subgraphs', subG.nodes[j], subG.id);
-      g.setParent(subG.nodes[j], subG.id);
+    for (const node of subG.nodes) {
+      log.info('Setting up subgraphs', node, subG.id);
+      g.setParent(node, subG.id);
     }
   }
   await addVertices(vert, g, id, root, doc, diagObj);
diff --git a/packages/mermaid/src/diagrams/flowchart/flowRenderer.js b/packages/mermaid/src/diagrams/flowchart/flowRenderer.js
index ca558987c..dbd39e712 100644
--- a/packages/mermaid/src/diagrams/flowchart/flowRenderer.js
+++ b/packages/mermaid/src/diagrams/flowchart/flowRenderer.js
@@ -339,14 +339,14 @@ export const draw = async function (text, id, _version, diagObj) {
 
     selectAll('cluster').append('text');
 
-    for (let j = 0; j < subG.nodes.length; j++) {
+    for (const subGNode of subG.nodes) {
       log.warn(
         'Setting subgraph',
-        subG.nodes[j],
-        diagObj.db.lookUpDomId(subG.nodes[j]),
+        subGNode,
+        diagObj.db.lookUpDomId(subGNode),
         diagObj.db.lookUpDomId(subG.id)
       );
-      g.setParent(diagObj.db.lookUpDomId(subG.nodes[j]), diagObj.db.lookUpDomId(subG.id));
+      g.setParent(diagObj.db.lookUpDomId(subGNode), diagObj.db.lookUpDomId(subG.id));
     }
   }
   await addVertices(vert, g, id, root, doc, diagObj);
@@ -429,8 +429,8 @@ export const draw = async function (text, id, _version, diagObj) {
       te.attr('transform', `translate(${xPos + _width / 2}, ${yPos + 14})`);
       te.attr('id', id + 'Text');
 
-      for (let j = 0; j < subG.classes.length; j++) {
-        clusterEl[0].classList.add(subG.classes[j]);
+      for (const subGClass of subG.classes) {
+        clusterEl[0].classList.add(subGClass);
       }
     }
   }
diff --git a/packages/mermaid/src/diagrams/state/stateRenderer-v2.js b/packages/mermaid/src/diagrams/state/stateRenderer-v2.js
index 0ecc0a73a..acb10427b 100644
--- a/packages/mermaid/src/diagrams/state/stateRenderer-v2.js
+++ b/packages/mermaid/src/diagrams/state/stateRenderer-v2.js
@@ -362,8 +362,7 @@ const setupDoc = (g, parentParsedItem, doc, diagramStates, diagramDb, altFlag) =
 const getDir = (parsedItem, defaultDir = DEFAULT_NESTED_DOC_DIR) => {
   let dir = defaultDir;
   if (parsedItem.doc) {
-    for (let i = 0; i < parsedItem.doc.length; i++) {
-      const parsedItemDoc = parsedItem.doc[i];
+    for (const parsedItemDoc of parsedItem.doc) {
       if (parsedItemDoc.stmt === 'dir') {
         dir = parsedItemDoc.value;
       }
diff --git a/packages/mermaid/src/diagrams/timeline/timelineRenderer.ts b/packages/mermaid/src/diagrams/timeline/timelineRenderer.ts
index c7d9bb5ae..eda53729e 100644
--- a/packages/mermaid/src/diagrams/timeline/timelineRenderer.ts
+++ b/packages/mermaid/src/diagrams/timeline/timelineRenderer.ts
@@ -115,8 +115,7 @@ export const draw = function (text: string, id: string, version: string, diagObj
     maxEventCount = Math.max(maxEventCount, task.events.length);
     //calculate maxEventLineLength
     let maxEventLineLengthTemp = 0;
-    for (let j = 0; j < task.events.length; j++) {
-      const event = task.events[j];
+    for (const event of task.events) {
       const eventNode = {
         descr: event,
         section: task.section,