From 3abd77a1e688f3f739baa30701d68daee82305e3 Mon Sep 17 00:00:00 2001 From: Gene Wood Date: Mon, 23 Dec 2019 08:02:11 -0800 Subject: [PATCH] Extend the `br` tag regex This extends the `br` tag regex to accommodate an arbitrary amount of any type of whitespace instead of a single space character, which holds more closely to the HTML spec[1] This extends the fix to #702 added in #1153 [1]: http://www.w3.org/TR/REC-xml/#sec-starttags --- src/diagrams/flowchart/flowRenderer.js | 2 +- src/diagrams/sequence/sequenceRenderer.js | 4 ++-- src/diagrams/sequence/svgDraw.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/diagrams/flowchart/flowRenderer.js b/src/diagrams/flowchart/flowRenderer.js index 524742b39..6528a361a 100644 --- a/src/diagrams/flowchart/flowRenderer.js +++ b/src/diagrams/flowchart/flowRenderer.js @@ -246,7 +246,7 @@ export const addEdges = function(edges, g) { edgeData.label = '' + edge.text + ''; } else { edgeData.labelType = 'text'; - edgeData.label = edge.text.replace(/
/g, '\n'); + edgeData.label = edge.text.replace(//g, '\n'); if (typeof edge.style === 'undefined') { edgeData.style = edgeData.style || 'stroke: #333; stroke-width: 1.5px;fill:none'; diff --git a/src/diagrams/sequence/sequenceRenderer.js b/src/diagrams/sequence/sequenceRenderer.js index b00ad38f0..56cd4303d 100644 --- a/src/diagrams/sequence/sequenceRenderer.js +++ b/src/diagrams/sequence/sequenceRenderer.js @@ -168,7 +168,7 @@ export const bounds = { const _drawLongText = (text, x, y, g, width) => { let textHeight = 0; - const lines = text.split(/
/gi); + const lines = text.split(//gi); for (const line of lines) { const textObj = svgDraw.getTextObj(); textObj.x = x; @@ -233,7 +233,7 @@ const drawMessage = function(elem, startx, stopx, verticalPos, msg, sequenceInde let textElem; let counterBreaklines = 0; let breaklineOffset = 17; - const breaklines = msg.message.split(/
/gi); + const breaklines = msg.message.split(//gi); for (const breakline of breaklines) { textElem = g .append('text') // text label for the x axis diff --git a/src/diagrams/sequence/svgDraw.js b/src/diagrams/sequence/svgDraw.js index 523c6cafd..d8047e403 100644 --- a/src/diagrams/sequence/svgDraw.js +++ b/src/diagrams/sequence/svgDraw.js @@ -18,7 +18,7 @@ export const drawRect = function(elem, rectData) { export const drawText = function(elem, textData) { // Remove and ignore br:s - const nText = textData.text.replace(/
/gi, ' '); + const nText = textData.text.replace(//gi, ' '); const textElem = elem.append('text'); textElem.attr('x', textData.x); @@ -321,7 +321,7 @@ const _drawTextCandidateFunc = (function() { function byTspan(content, g, x, y, width, height, textAttrs, conf) { const { actorFontSize, actorFontFamily } = conf; - const lines = content.split(/
/gi); + const lines = content.split(//gi); for (let i = 0; i < lines.length; i++) { const dy = i * actorFontSize - (actorFontSize * (lines.length - 1)) / 2; const text = g