ci(e2e): avoid commenting on PRs in CI

GitHub Actions can't comment on PRs, if the PR is made from a forked
repo, as [the github token won't have write permissions][1].

However, we can instead use GitHub Actions' [Adding a Job Summary][2]
feature, which prints some custom output for each job.

[1]: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#changing-the-permissions-in-a-forked-repository
[2]: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary

Fix: e0448a7b7b
This commit is contained in:
Alois Klink
2024-03-06 18:23:06 +00:00
parent 821076ba9c
commit 46136b5632

View File

@@ -15,7 +15,6 @@ on:
permissions: permissions:
contents: read contents: read
pull-requests: write
env: env:
# For PRs and MergeQueues, the target commit is used, and for push events, github.event.previous is used. # For PRs and MergeQueues, the target commit is used, and for push events, github.event.previous is used.
@@ -56,8 +55,8 @@ jobs:
# just perform install # just perform install
runTests: false runTests: false
- name: Build - name: Calculate bundle size
if: ${{ steps.cache-snapshot.outputs.cache-hit != 'true' && github.event_name == 'pull_request' }} if: ${{ steps.cache-snapshot.outputs.cache-hit != 'true'}}
run: | run: |
pnpm run build:viz pnpm run build:viz
mkdir -p cypress/snapshots/stats/base mkdir -p cypress/snapshots/stats/base
@@ -107,26 +106,14 @@ jobs:
with: with:
runTests: false runTests: false
- name: Build - name: Output size diff
id: size if: ${{ matrix.containers == 1 }}
if: ${{ github.event_name == 'pull_request' && matrix.containers == 1 }}
run: | run: |
pnpm run build:viz pnpm run build:viz
mv stats cypress/snapshots/stats/head mv stats cypress/snapshots/stats/head
{ echo '## Bundle size difference' >> "$GITHUB_STEP_SUMMARY"
echo 'size_diff<<EOF' echo '' >> "$GITHUB_STEP_SUMMARY"
npx tsx scripts/size.ts npx tsx scripts/size.ts >> "$GITHUB_STEP_SUMMARY"
echo EOF
} >> "$GITHUB_OUTPUT"
# Size diff only needs to be posted from one job, on PRs.
- name: Comment PR size difference
if: ${{ github.event_name == 'pull_request' && matrix.containers == 1 }}
uses: thollander/actions-comment-pull-request@v2
with:
message: |
${{ steps.size.outputs.size_diff }}
comment_tag: size-diff
# Install NPM dependencies, cache them correctly # Install NPM dependencies, cache them correctly
# and run all Cypress tests # and run all Cypress tests