From 3754ac08724be638d2c3dd6c944457c7df5397c2 Mon Sep 17 00:00:00 2001 From: Ronid1 Date: Thu, 6 Jun 2024 18:15:11 -0700 Subject: [PATCH 1/2] fix note z position --- packages/mermaid/src/diagrams/sequence/svgDraw.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/mermaid/src/diagrams/sequence/svgDraw.js b/packages/mermaid/src/diagrams/sequence/svgDraw.js index 568074b53..848455f78 100644 --- a/packages/mermaid/src/diagrams/sequence/svgDraw.js +++ b/packages/mermaid/src/diagrams/sequence/svgDraw.js @@ -415,11 +415,11 @@ const drawActorTypeActor = async function (elem, actor, conf, isFooter) { const center = actor.x + actor.width / 2; const centerY = actorY + 80; - elem.lower(); + const line = elem.append('g').lower(); if (!isFooter) { actorCnt++; - elem + line .append('line') .attr('id', 'actor' + actorCnt) .attr('x1', center) From b285466130fed911e4c9d82ed9179246b7ee1a70 Mon Sep 17 00:00:00 2001 From: Ronid1 Date: Thu, 6 Jun 2024 18:33:55 -0700 Subject: [PATCH 2/2] add integration test --- .../integration/rendering/sequencediagram.spec.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/cypress/integration/rendering/sequencediagram.spec.js b/cypress/integration/rendering/sequencediagram.spec.js index 1285a0832..8e15f3fac 100644 --- a/cypress/integration/rendering/sequencediagram.spec.js +++ b/cypress/integration/rendering/sequencediagram.spec.js @@ -464,6 +464,18 @@ context('Sequence diagram', () => { {} ); }); + it('should render notes over actors and participant', () => { + imgSnapshotTest( + ` + sequenceDiagram + actor Alice + participant Charlie + note over Alice: some note + note over Charlie: other note + `, + {} + ); + }); it('should render long messages from an actor to the left to one to the right', () => { imgSnapshotTest( `