marcel/mermaid
1
0
Fork 0
mirror of https://github.com/mermaid-js/mermaid.git synced 2025-09-26 10:49:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

GitGraph: made reroute fn more readable

Browse Source 
Pre-commit lint hook had made the use of ternaries harder to read
than I'd originally intended so I introduced an additional
variable which explains what is being checked and keeps ternaries
from becoming obscured.
This commit is contained in:
Guy Pursey
2023-10-27 12:11:27 +01:00
parent a9c5d903c5
commit 57a9d7356c
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/mermaid/src/diagrams/git/gitGraphRenderer.js
View File

@@ -359,9 +359,8 @@ const drawCommits = (svg, commits, modifyGraph) => {
* return true * return true
*/ */
const shouldRerouteArrow = (commitA, commitB, p1, p2, allCommits) => { const shouldRerouteArrow = (commitA, commitB, p1, p2, allCommits) => {
const branchToGetCurve = (dir === 'TB' ? p1.x < p2.x : p1.y < p2.y) const commitBIsFurthest = dir === 'TB' ? p1.x < p2.x : p1.y < p2.y;
? commitB.branch const branchToGetCurve = commitBIsFurthest ? commitB.branch : commitA.branch;
: commitA.branch;
const isOnBranchToGetCurve = (x) => x.branch === branchToGetCurve; const isOnBranchToGetCurve = (x) => x.branch === branchToGetCurve;
const isBetweenCommits = (x) => x.seq > commitA.seq && x.seq < commitB.seq; const isBetweenCommits = (x) => x.seq > commitA.seq && x.seq < commitB.seq;
return Object.values(allCommits).some((commitX) => { return Object.values(allCommits).some((commitX) => {