From 901df242b78a69bf104c97b154695dd902c7a1e1 Mon Sep 17 00:00:00 2001 From: Gijs van Dam Date: Fri, 1 Feb 2019 13:28:12 +0800 Subject: [PATCH] Replace multiple returns with single return --- src/diagrams/gantt/ganttRenderer.js | 41 ++++++++++++++--------------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/src/diagrams/gantt/ganttRenderer.js b/src/diagrams/gantt/ganttRenderer.js index 0529e3b06..c25724b70 100644 --- a/src/diagrams/gantt/ganttRenderer.js +++ b/src/diagrams/gantt/ganttRenderer.js @@ -159,32 +159,31 @@ export const draw = function (text, id) { } } - let milestone = '' - if (d.milestone) { - milestone = ' milestone' - } - + let taskClass = '' if (d.active) { - if (d.crit) { - return res + milestone + ' activeCrit' + secNum - } else { - return res + milestone + ' active' + secNum - } + taskClass = ' active' + } else if (d.done) { + taskClass = ' done' } - - if (d.done) { - if (d.crit) { - return res + milestone + ' doneCrit' + secNum - } else { - return res + milestone + ' done' + secNum - } - } - if (d.crit) { - return res + milestone + ' crit' + secNum + if (taskClass.length > 0) { + taskClass += 'Crit' + } else { + taskClass = ' crit' + } } - return res + milestone + ' task' + secNum + if (taskClass.length === 0) { + taskClass = ' task' + } + + if (d.milestone) { + taskClass = ' milestone' + taskClass + } + + taskClass += secNum + + return res + taskClass }) // Append task labels