marcel/mermaid
1
0
Fork 0
mirror of https://github.com/mermaid-js/mermaid.git synced 2025-09-19 15:30:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Sequence diagram loop rendering

Browse Source
This commit is contained in:
Sidharth Vinod
2023-09-26 18:36:05 +05:30
parent ad596086ea
commit a3456ec933
1 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts
View File

@@ -1421,6 +1421,13 @@ const buildMessageModel = function (msg, actors, diagObj) {
return isArrowToRight ? -value : value; return isArrowToRight ? -value : value;
}; };
// 3 is max difference for +/- 1
if (Math.abs(startx - stopx) <= 3) {
// This is a self reference, so we need to make sure the arrow is drawn correctly
// There are many checks in the downstream rendering that checks for equality.
// The lines on loops will be off by few pixels, but that's fine for now.
stopx = startx;
} else {
/** /**
* This is an edge case for the first activation. * This is an edge case for the first activation.
* Proper fix would require significant changes. * Proper fix would require significant changes.
@@ -1439,6 +1446,7 @@ const buildMessageModel = function (msg, actors, diagObj) {
if (![diagObj.db.LINETYPE.SOLID_OPEN, diagObj.db.LINETYPE.DOTTED_OPEN].includes(msg.type)) { if (![diagObj.db.LINETYPE.SOLID_OPEN, diagObj.db.LINETYPE.DOTTED_OPEN].includes(msg.type)) {
stopx += adjustValue(3); stopx += adjustValue(3);
} }
}
const allBounds = [fromLeft, fromRight, toLeft, toRight]; const allBounds = [fromLeft, fromRight, toLeft, toRight];
const boundedWidth = Math.abs(startx - stopx); const boundedWidth = Math.abs(startx - stopx);