marcel/mermaid
1
0
Fork 0
mirror of https://github.com/mermaid-js/mermaid.git synced 2025-09-14 12:59:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Added sanitization of the links to prevent script injection attacks.

Browse Source
This commit is contained in:
eajenkins
2021-09-02 11:59:43 -07:00
parent ce6d8576ae
commit b3210ed2ef
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/diagrams/sequence/svgDraw.js
View File

@@ -18,6 +18,10 @@ export const drawRect = function (elem, rectData) {
return rectElem; return rectElem;
}; };
const sanitizeUrl = function (s) {
return s.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/"/g, '&quot;').replace(/'/g, '&apos;').replace(/javascript:/g, '');
}
export const drawPopup = function (elem, actor, minMenuWidth, textAttrs, forceMenus) { export const drawPopup = function (elem, actor, minMenuWidth, textAttrs, forceMenus) {
if (actor.links === undefined || actor.links === null || Object.keys(actor.links).length === 0) { if (actor.links === undefined || actor.links === null || Object.keys(actor.links).length === 0) {
@@ -61,7 +65,8 @@ export const drawPopup = function (elem, actor, minMenuWidth, textAttrs, forceMe
var linkY = 20; var linkY = 20;
for (let key in links) { for (let key in links) {
var linkElem = g.append('a'); var linkElem = g.append('a');
linkElem.attr('xlink:href', links[key]); var sanitizedLink = sanitizeUrl(links[key]);
linkElem.attr('xlink:href', sanitizedLink);
linkElem.attr('target', '_blank'); linkElem.attr('target', '_blank');
_drawMenuItemTextCandidateFunc(textAttrs)( _drawMenuItemTextCandidateFunc(textAttrs)(
@@ -88,14 +93,16 @@ export const drawImage = function (elem, x, y, link) {
const imageElem = elem.append('image'); const imageElem = elem.append('image');
imageElem.attr('x', x); imageElem.attr('x', x);
imageElem.attr('y', y); imageElem.attr('y', y);
imageElem.attr('xlink:href', link); var sanitizedLink = sanitizeUrl(link);
imageElem.attr('xlink:href', sanitizedLink);
} }
export const drawEmbeddedImage = function (elem, x, y, link) { export const drawEmbeddedImage = function (elem, x, y, link) {
const imageElem = elem.append('use'); const imageElem = elem.append('use');
imageElem.attr('x', x); imageElem.attr('x', x);
imageElem.attr('y', y); imageElem.attr('y', y);
imageElem.attr('xlink:href', '#' + link); var sanitizedLink = sanitizeUrl(link);
imageElem.attr('xlink:href', '#' + sanitizedLink);
} }
export const popupMenu = function (popid) { export const popupMenu = function (popid) {