From 4db72f5357b7e0ca2d1882219d423d1fb2529748 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 18 Aug 2025 11:31:20 +0000 Subject: [PATCH 1/4] chore(deps): update peter-evans/create-pull-request digest to cb4d3bf --- .github/workflows/e2e-timings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-timings.yml b/.github/workflows/e2e-timings.yml index f4c28acad..2bbfa8412 100644 --- a/.github/workflows/e2e-timings.yml +++ b/.github/workflows/e2e-timings.yml @@ -58,7 +58,7 @@ jobs: echo "EOF" >> $GITHUB_OUTPUT - name: Commit and create pull request - uses: peter-evans/create-pull-request@1310d7dab503600742045e6fd4b84dda64352858 + uses: peter-evans/create-pull-request@cb4d3bfce175d44325c6b7697f81e0afe8a79bdf with: add-paths: | cypress/timings.json From c534d3d364813e068ef8779d9bad26f5a06d0c26 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Mon, 18 Aug 2025 11:46:12 +0000 Subject: [PATCH 2/4] [autofix.ci] apply automated fixes --- docs/syntax/pie.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/syntax/pie.md b/docs/syntax/pie.md index 6a2eefb27..fd5ec1db0 100644 --- a/docs/syntax/pie.md +++ b/docs/syntax/pie.md @@ -39,7 +39,7 @@ Drawing a pie chart is really simple in mermaid. **Note:** -> Pie chart values must be **positive numbers greater than zero**.\ +> Pie chart values must be **positive numbers greater than zero**. > **Negative values are not allowed** and will result in an error. \[pie] \[showData] (OPTIONAL) From d4c76968e97b3049e8975113fb4d9d244f41df43 Mon Sep 17 00:00:00 2001 From: darshanr0107 Date: Thu, 21 Aug 2025 19:09:39 +0530 Subject: [PATCH 3/4] fix: correct rendering of bidirectional arrows with autonumber on-behalf-of: @Mermaid-Chart --- .../rendering/sequencediagram.spec.js | 11 +++++++++ .../src/diagrams/sequence/sequenceRenderer.ts | 24 ++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/cypress/integration/rendering/sequencediagram.spec.js b/cypress/integration/rendering/sequencediagram.spec.js index f18e99abf..6709b557c 100644 --- a/cypress/integration/rendering/sequencediagram.spec.js +++ b/cypress/integration/rendering/sequencediagram.spec.js @@ -893,6 +893,17 @@ describe('Sequence diagram', () => { } ); }); + + it('should handle bidirectional arrows with autonumber', () => { + imgSnapshotTest(` + sequenceDiagram + autonumber + participant A + participant B + A<<->>B: This is a bidirectional message + A->B: This is a normal message`); + }); + it('should support actor links and properties when not mirrored EXPERIMENTAL: USE WITH CAUTION', () => { //Be aware that the syntax for "properties" is likely to be changed. imgSnapshotTest( diff --git a/packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts b/packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts index cfba92b79..2c0d898ca 100644 --- a/packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts +++ b/packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts @@ -476,7 +476,29 @@ const drawMessage = async function (diagram, msgModel, lineStartY: number, diagO // add node number if (sequenceVisible || conf.showSequenceNumbers) { - line.attr('marker-start', 'url(' + url + '#sequencenumber)'); + const isBidirectional = + type === diagObj.db.LINETYPE.BIDIRECTIONAL_SOLID || + type === diagObj.db.LINETYPE.BIDIRECTIONAL_DOTTED; + + if (isBidirectional) { + const SEQUENCE_NUMBER_RADIUS = 6; + + if (startx < stopx) { + line.attr('x1', startx + 2 * SEQUENCE_NUMBER_RADIUS); + } else { + line.attr('x1', startx + SEQUENCE_NUMBER_RADIUS); + } + } + + diagram + .append('line') + .attr('x1', startx) + .attr('y1', lineStartY) + .attr('x2', startx) + .attr('y2', lineStartY) + .attr('stroke-width', 0) + .attr('marker-start', 'url(' + url + '#sequencenumber)'); + diagram .append('text') .attr('x', startx) From e0b45c2d2b41c2a9038bf87646fa3ccd7560eb20 Mon Sep 17 00:00:00 2001 From: darshanr0107 Date: Thu, 21 Aug 2025 19:15:30 +0530 Subject: [PATCH 4/4] chore: added changeset on-behalf-of: @Mermaid-Chart --- .changeset/crazy-loops-matter.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/crazy-loops-matter.md diff --git a/.changeset/crazy-loops-matter.md b/.changeset/crazy-loops-matter.md new file mode 100644 index 000000000..e6377a9e5 --- /dev/null +++ b/.changeset/crazy-loops-matter.md @@ -0,0 +1,5 @@ +--- +'mermaid': patch +--- + +fix: Handle arrows correctly when auto number is enabled