Added review changes

cypress/integration/rendering/xyChart.spec.js

@@ -4,8 +4,8 @@ describe('XY Chart', () => {
   it('should render the simplest possible chart', () => {
     imgSnapshotTest(
       `
-  xychart-beta
-    line [10, 30, 20]
+      xychart-beta
+        line [10, 30, 20]
       `,
       {}
     );
@@ -14,12 +14,12 @@ describe('XY Chart', () => {
   it('Should render a complete chart', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -27,11 +27,11 @@ describe('XY Chart', () => {
   it('Should render a chart without title', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      xychart-beta
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -40,11 +40,11 @@ describe('XY Chart', () => {
   it('y-axis title not required', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      xychart-beta
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -53,10 +53,10 @@ describe('XY Chart', () => {
   it('Should render a chart without y-axis with different range', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 14000, 3200, 9200, 9900, 3400, 6000]
-      line [2000, 7000, 6500, 9200, 9500, 7500, 11000, 10200, 3200, 8500, 7000, 8800]
+      xychart-beta
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 14000, 3200, 9200, 9900, 3400, 6000]
+        line [2000, 7000, 6500, 9200, 9500, 7500, 11000, 10200, 3200, 8500, 7000, 8800]
       `,
       {}
     );
@@ -65,10 +65,10 @@ describe('XY Chart', () => {
   it('x axis title not required', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      x-axis [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 14000, 3200, 9200, 9900, 3400, 6000]
-      line [2000, 7000, 6500, 9200, 9500, 7500, 11000, 10200, 3200, 8500, 7000, 8800]
+      xychart-beta
+        x-axis [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 14000, 3200, 9200, 9900, 3400, 6000]
+        line [2000, 7000, 6500, 9200, 9500, 7500, 11000, 10200, 3200, 8500, 7000, 8800]
       `,
       {}
     );
@@ -77,24 +77,24 @@ describe('XY Chart', () => {
   it('Multiple plots can be rendered', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      line [23, 46, 77, 34]
-      line [45, 32, 33, 12]
-      bar [87, 54, 99, 85]
-      line [78, 88, 22, 4]
-      line [22, 29, 75, 33]
-      bar [52, 96, 35, 10]
+      xychart-beta
+        line [23, 46, 77, 34]
+        line [45, 32, 33, 12]
+        bar [87, 54, 99, 85]
+        line [78, 88, 22, 4]
+        line [22, 29, 75, 33]
+        bar [52, 96, 35, 10]
       `,
       {}
     );
     cy.get('svg');
   });
-  it('Decimals and -ve no are supported', () => {
+  it('Decimals and negative numbers are supported', () => {
     imgSnapshotTest(
       `
-    xychart-beta
-      y-axis -2.4 --> 3.5
-      line [+1.3, .6, 2.4, -.34]
+      xychart-beta
+        y-axis -2.4 --> 3.5
+        line [+1.3, .6, 2.4, -.34]
       `,
       {}
     );
@@ -103,16 +103,16 @@ describe('XY Chart', () => {
   it('Render spark line with "plotReservedSpacePercent"', () => {
     imgSnapshotTest(
       `
----
-config:
-  theme: dark
-  xyChart:
-    width: 200
-    height: 20
-    plotReservedSpacePercent: 100
----
-    xychart-beta
-      line [5000, 9000, 7500, 6200, 9500, 5500, 11000, 8200, 9200, 9500, 7000, 8800]
+      ---
+      config:
+        theme: dark
+        xyChart:
+          width: 200
+          height: 20
+          plotReservedSpacePercent: 100
+      ---
+      xychart-beta
+        line [5000, 9000, 7500, 6200, 9500, 5500, 11000, 8200, 9200, 9500, 7000, 8800]
       `,
       {}
     );
@@ -121,25 +121,25 @@ config:
   it('Render spark bar without displaying other property', () => {
     imgSnapshotTest(
       `
----
-config:
-  theme: dark
-  xyChart:
-    width: 200
-    height: 20
-    xAxis:
-      showLabel: false
-      showTitle: false
-      showTick: false
-      showAxisLine: false
-    yAxis:
-      showLabel: false
-      showTitle: false
-      showTick: false
-      showAxisLine: false
----
-    xychart-beta
-      bar [5000, 9000, 7500, 6200, 9500, 5500, 11000, 8200, 9200, 9500, 7000, 8800]
+      ---
+      config:
+        theme: dark
+        xyChart:
+          width: 200
+          height: 20
+          xAxis:
+            showLabel: false
+            showTitle: false
+            showTick: false
+            showAxisLine: false
+          yAxis:
+            showLabel: false
+            showTitle: false
+            showTick: false
+            showAxisLine: false
+      ---
+      xychart-beta
+        bar [5000, 9000, 7500, 6200, 9500, 5500, 11000, 8200, 9200, 9500, 7000, 8800]
       `,
       {}
     );
@@ -148,13 +148,13 @@ config:
   it('Should use all the config from directive', () => {
     imgSnapshotTest(
       `
-    %%{init: {"xyChart": {"width": 1000, "height": 600, "titlePadding": 5, "titleFontSize": 10, "xAxis": {"labelFontSize": "20", "labelPadding": 10, "titleFontSize": 30, "titlePadding": 20, "tickLength": 10, "tickWidth": 5},  "yAxis": {"labelFontSize": "20", "labelPadding": 10, "titleFontSize": 30, "titlePadding": 20, "tickLength": 10, "tickWidth": 5}, "plotBorderWidth": 5, "chartOrientation": "horizontal", "plotReservedSpacePercent": 60  }}}%%
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      %%{init: {"xyChart": {"width": 1000, "height": 600, "titlePadding": 5, "titleFontSize": 10, "xAxis": {"labelFontSize": "20", "labelPadding": 10, "titleFontSize": 30, "titlePadding": 20, "tickLength": 10, "tickWidth": 5},  "yAxis": {"labelFontSize": "20", "labelPadding": 10, "titleFontSize": 30, "titlePadding": 20, "tickLength": 10, "tickWidth": 5}, "plotBorderWidth": 5, "chartOrientation": "horizontal", "plotReservedSpacePercent": 60  }}}%%
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -163,39 +163,39 @@ config:
   it('Should use all the config from yaml', () => {
     imgSnapshotTest(
       `
----
-config:
-  theme: forest
-  xyChart:
-    width: 1000
-    height: 600
-    titlePadding: 5
-    titleFontSize: 10
-    xAxis:
-      labelFontSize: 20
-      labelPadding: 10
-      titleFontSize: 30
-      titlePadding: 20
-      tickLength: 10
-      tickWidth: 5
-      axisLineWidth: 5
-    yAxis:
-      labelFontSize: 20
-      labelPadding: 10
-      titleFontSize: 30
-      titlePadding: 20
-      tickLength: 10
-      tickWidth: 5
-      axisLineWidth: 5
-    chartOrientation: horizontal
-    plotReservedSpacePercent: 60
----
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      ---
+      config:
+        theme: forest
+        xyChart:
+          width: 1000
+          height: 600
+          titlePadding: 5
+          titleFontSize: 10
+          xAxis:
+            labelFontSize: 20
+            labelPadding: 10
+            titleFontSize: 30
+            titlePadding: 20
+            tickLength: 10
+            tickWidth: 5
+            axisLineWidth: 5
+          yAxis:
+            labelFontSize: 20
+            labelPadding: 10
+            titleFontSize: 30
+            titlePadding: 20
+            tickLength: 10
+            tickWidth: 5
+            axisLineWidth: 5
+          chartOrientation: horizontal
+          plotReservedSpacePercent: 60
+      ---
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -204,20 +204,20 @@ config:
   it('Render with show axis title false', () => {
     imgSnapshotTest(
       `
----
-config:
-  xyChart:
-    xAxis:
-      showTitle: false
-    yAxis:
-      showTitle: false
----
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      ---
+      config:
+        xyChart:
+          xAxis:
+            showTitle: false
+          yAxis:
+            showTitle: false
+      ---
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -226,20 +226,20 @@ config:
   it('Render with show axis label false', () => {
     imgSnapshotTest(
       `
----
-config:
-  xyChart:
-    xAxis:
-      showLabel: false
-    yAxis:
-      showLabel: false
----
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      ---
+      config:
+        xyChart:
+          xAxis:
+            showLabel: false
+          yAxis:
+            showLabel: false
+      ---
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -248,20 +248,20 @@ config:
   it('Render with show axis tick false', () => {
     imgSnapshotTest(
       `
----
-config:
-  xyChart:
-    xAxis:
-      showTick: false
-    yAxis:
-      showTick: false
----
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      ---
+      config:
+        xyChart:
+          xAxis:
+            showTick: false
+          yAxis:
+            showTick: false
+      ---
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -270,20 +270,20 @@ config:
   it('Render with show axis line false', () => {
     imgSnapshotTest(
       `
----
-config:
-  xyChart:
-    xAxis:
-      showAxisLine: false
-    yAxis:
-      showAxisLine: false
----
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      ---
+      config:
+        xyChart:
+          xAxis:
+            showAxisLine: false
+          yAxis:
+            showAxisLine: false
+      ---
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );
@@ -292,28 +292,28 @@ config:
   it('Render all the theme color', () => {
     imgSnapshotTest(
       `
----
-config:
-  themeVariables:
-    xyChart:
-      titleColor: "#ff0000"
-      backgroundColor: "#f0f8ff"
-      yAxisLabelColor: "#ee82ee"
-      yAxisTitleColor: "#7fffd4"
-      yAxisTickColor: "#87ceeb"
-      yAxisLineColor: "#ff6347"
-      xAxisLabelColor: "#7fffd4"
-      xAxisTitleColor: "#ee82ee"
-      xAxisTickColor: "#ff6347"
-      xAxisLineColor: "#87ceeb"
-      plotColorPalette: "#008000, #faba63"
----
-    xychart-beta
-      title "Sales Revene"
-      x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
-      y-axis "Revenue (in $)" 4000 --> 11000
-      bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
-      line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+      ---
+      config:
+        themeVariables:
+          xyChart:
+            titleColor: "#ff0000"
+            backgroundColor: "#f0f8ff"
+            yAxisLabelColor: "#ee82ee"
+            yAxisTitleColor: "#7fffd4"
+            yAxisTickColor: "#87ceeb"
+            yAxisLineColor: "#ff6347"
+            xAxisLabelColor: "#7fffd4"
+            xAxisTitleColor: "#ee82ee"
+            xAxisTickColor: "#ff6347"
+            xAxisLineColor: "#87ceeb"
+            plotColorPalette: "#008000, #faba63"
+      ---
+      xychart-beta
+        title "Sales Revenue"
+        x-axis Months [jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec]
+        y-axis "Revenue (in $)" 4000 --> 11000
+        bar [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
+        line [5000, 6000, 7500, 8200, 9500, 10500, 11000, 10200, 9200, 8500, 7000, 6000]
       `,
       {}
     );