From f87d0dd88ae4db3231ce1a4dfe20b2d07389a938 Mon Sep 17 00:00:00 2001 From: Sidharth Vinod Date: Wed, 9 Apr 2025 13:20:19 +0530 Subject: [PATCH] chore: Update change detection logic --- scripts/compare-timings.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/scripts/compare-timings.ts b/scripts/compare-timings.ts index aaf070767..1dbfc41d0 100644 --- a/scripts/compare-timings.ts +++ b/scripts/compare-timings.ts @@ -91,20 +91,22 @@ function compareTimings(): void { if (!oldTiming) { throw new Error(`Could not find old timing for spec: ${newTiming.spec}`); } - const change = Math.abs(newTiming.duration - oldTiming.duration) / oldTiming.duration; - return { spec: newTiming.spec, change }; + const change = Math.abs(newTiming.duration - oldTiming.duration); + const changePercent = change / oldTiming.duration; + return { spec: newTiming.spec, change, changePercent }; }); - const significantChanges = timingChanges.filter((t) => t.change >= 0.2); + // Filter changes that's more than 5 seconds and 20% different + const significantChanges = timingChanges.filter((t) => t.change > 5000 && t.changePercent >= 0.2); if (significantChanges.length === 0) { - log('No significant timing changes detected (threshold: 20%)'); + log('No significant timing changes detected (threshold: 5s and 20%)'); return cleanupFiles({ keepNew: false, reason: 'No significant timing changes' }); } log('Significant timing changes:'); significantChanges.forEach((t) => { - log(`${t.spec}: ${(t.change * 100).toFixed(1)}%`); + log(`${t.spec}: ${t.change.toFixed(1)}ms (${(t.changePercent * 100).toFixed(1)}%)`); }); cleanupFiles({ keepNew: true, reason: 'Significant timing changes detected' });