From 8a8ec1cb0be387121ba13b0ac1b450952d80bd53 Mon Sep 17 00:00:00 2001 From: Kawin Viriyaprasopsook Date: Wed, 24 Jul 2024 14:59:48 +0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20randIndex=20for=20fallbackUpstre?= =?UTF-8?q?ams=20random?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/mod/dynamicproxy/loadbalance/originPicker.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mod/dynamicproxy/loadbalance/originPicker.go b/src/mod/dynamicproxy/loadbalance/originPicker.go index da4423e..ad77472 100644 --- a/src/mod/dynamicproxy/loadbalance/originPicker.go +++ b/src/mod/dynamicproxy/loadbalance/originPicker.go @@ -130,8 +130,8 @@ func getRandomUpstreamByWeight(upstreams []*Upstream) (*Upstream, int, error) { if totalWeight == 0 { if len(fallbackUpstreams) > 0 { // Randomly select one of the fallback upstreams - index := rand.Intn(len(fallbackUpstreams)) - return fallbackUpstreams[index].Upstream, fallbackUpstreams[index].Index, nil + randIndex := rand.Intn(len(fallbackUpstreams)) + return fallbackUpstreams[randIndex].Upstream, fallbackUpstreams[randIndex].Index, nil } // No upstreams available at all return nil, -1, errors.New("no valid upstream servers available") @@ -153,8 +153,8 @@ func getRandomUpstreamByWeight(upstreams []*Upstream) (*Upstream, int, error) { // If we reach here, it means we should return a fallback upstream if available if len(fallbackUpstreams) > 0 { - index := rand.Intn(len(fallbackUpstreams)) - return fallbackUpstreams[index].Upstream, fallbackUpstreams[index].Index, nil + randIndex := rand.Intn(len(fallbackUpstreams)) + return fallbackUpstreams[randIndex].Upstream, fallbackUpstreams[randIndex].Index, nil } return nil, -1, errors.New("failed to pick an upstream origin server")