marcel/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-09-23 17:30:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Actual segments not approximations

Browse Source
This commit is contained in:
Mark Tolmacs
2025-09-22 17:05:07 +02:00
parent 54ca52e063
commit 06251ef8ed
1 changed files with 31 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
packages/element/src/bounds.ts
View File

@@ -322,38 +322,42 @@ export const getElementLineSegments = (
if (shape.type === "polycurve") {
const curves = shape.data;
const points = curves
.map((curve) => pointsOnBezierCurves(curve, 10))
.flat();
const pointsOnCurves = curves.map((curve) =>
pointsOnBezierCurves(curve, 10),
);
const segments: LineSegment<GlobalPoint>[] = [];
let i = 0;
if (
(isLineElement(element) && !element.polygon) ||
isArrowElement(element)
) {
for (const points of pointsOnCurves) {
let i = 0;
while (i < points.length - 1) {
const p1 = pointFrom(points[i + 1][0], points[i][1]);
const p2 = pointFrom(points[i][0], points[i + 1][1]);
const alignsWithStart = pointDistance(p1, points[0] as GlobalPoint) < 1;
const alignsWithEnd =
pointDistance(p2, points[points.length - 1] as GlobalPoint) < 1;
// Avoid closing the polycurve for non-polygon lines and arrows
if (
((isLineElement(element) && !element.polygon) ||
isArrowElement(element)) &&
alignsWithStart &&
alignsWithEnd
) {
i++;
continue;
while (i < points.length - 1) {
segments.push(
lineSegment(
pointFrom(points[i][0], points[i][1]),
pointFrom(points[i + 1][0], points[i + 1][1]),
),
);
i++;
}
}
} else {
const points = pointsOnCurves.flat();
let i = 0;
segments.push(
lineSegment(
pointFrom(points[i][0], points[i][1]),
pointFrom(points[i + 1][0], points[i + 1][1]),
),
);
i++;
while (i < points.length - 1) {
segments.push(
lineSegment(
pointFrom(points[i][0], points[i][1]),
pointFrom(points[i + 1][0], points[i + 1][1]),
),
);
i++;
}
}
return segments;